Skip to content

Use Threads.@spawn instead of @async #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use Threads.@spawn instead of @async #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/worker.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ interrupt(::Nothing) = nothing
function handle(::Val{MsgType.from_host_call_with_response}, socket, msg, msg_id::MsgID)
f, args, kwargs, respond_with_nothing = msg

@async begin
Threads.@spawn begin
result, success = try
result = f(args...; kwargs...)

Expand All @@ -139,7 +139,7 @@ end
function handle(::Val{MsgType.from_host_call_without_response}, socket, msg, msg_id::MsgID)
f, args, kwargs, _ignored = msg

@async try
Threads.@spawn try
f(args...; kwargs...)
catch e
@warn("WORKER: Got exception while running call without response", exception=(e, catch_backtrace()))
Expand Down