Skip to content

Do not rewrite ^(_, ::Int) with NaNMath.pow #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not rewrite ^(_, ::Int) with NaNMath.pow #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "SymbolicUtils"
uuid = "d1185830-fcd6-423d-90d6-eec64667417b"
authors = ["Shashi Gowda"]
version = "3.8.1"
version = "3.8.2"

[deps]
AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
Expand Down
9 changes: 6 additions & 3 deletions src/code.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,15 @@ function function_to_expr(op::typeof(^), O, st)
return toexpr(Term(inv, Any[ex]), st)
else
args = Any[Term(inv, Any[ex]), -args[2]]
op = get(st.rewrites, :nanmath, false) ? op : NaNMath.pow
op = get(st.rewrites, :nanmath, false) === true && !(args[2] isa Int) ? NaNMath.pow : op
return toexpr(Term(op, args), st)
end
end
get(st.rewrites, :nanmath, false) === true || return nothing
return toexpr(Term(NaNMath.pow, args), st)
if get(st.rewrites, :nanmath, false) === true && !(args[2] isa Int)
return toexpr(Term(NaNMath.pow, args), st)
else
return nothing
end
end

function function_to_expr(::typeof(SymbolicUtils.ifelse), O, st)
Expand Down
14 changes: 12 additions & 2 deletions test/code.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,20 +100,30 @@ nanmath_st.rewrites[:nanmath] = true
@test toexpr(NaNMath.pow(a, b), nanmath_st) == :($(NaNMath.pow)(a, b))

@test toexpr(a^2) == :($(^)(a, 2))
@test toexpr(a^2, nanmath_st) == :($(NaNMath.pow)(a, 2))
@test toexpr(a^2, nanmath_st) == :($(^)(a, 2))
@test toexpr(NaNMath.pow(a, 2)) == :($(NaNMath.pow)(a, 2))
@test toexpr(NaNMath.pow(a, 2), nanmath_st) == :($(NaNMath.pow)(a, 2))

@test toexpr(a^3.1) == :($(^)(a, 3.1))
@test toexpr(a^3.1, nanmath_st) == :($(NaNMath.pow)(a, 3.1))
@test toexpr(NaNMath.pow(a, 3.1)) == :($(NaNMath.pow)(a, 3.1))
@test toexpr(NaNMath.pow(a, 3.1), nanmath_st) == :($(NaNMath.pow)(a, 3.1))

@test toexpr(a^-1) == :($(/)(1, a))
@test toexpr(a^-1, nanmath_st) == :($(/)(1, a))
@test toexpr(NaNMath.pow(a, -1)) == :($(NaNMath.pow)(a, -1))
@test toexpr(NaNMath.pow(a, -1), nanmath_st) == :($(NaNMath.pow)(a, -1))

@test toexpr(a^-2) == :($(/)(1, $(^)(a, 2)))
@test toexpr(a^-2, nanmath_st) == :($(/)(1, $(NaNMath.pow)(a, 2)))
@test toexpr(a^-2, nanmath_st) == :($(/)(1, $(^)(a, 2)))
@test toexpr(NaNMath.pow(a, -2)) == :($(NaNMath.pow)(a, -2))
@test toexpr(NaNMath.pow(a, -2), nanmath_st) == :($(NaNMath.pow)(a, -2))

@test toexpr(a^-2.4) == :($(/)(1, $(^)(a, 2.4)))
@test toexpr(a^-2.4, nanmath_st) == :($(/)(1, $(NaNMath.pow)(a, 2.4)))
@test toexpr(NaNMath.pow(a, -2.4)) == :($(NaNMath.pow)(a, -2.4))
@test toexpr(NaNMath.pow(a, -2.4), nanmath_st) == :($(NaNMath.pow)(a, -2.4))

f = GlobalRef(NaNMath, :sin)
test_repr(toexpr(LiteralExpr(:(let x=1, y=2
$(sin(a+b))
Expand Down
Loading