RFC ShortString based isbits #333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak comment tweak comment do use split with short strings Julia needs brakets for function application
make explict that Type and StepRange are for any <:ZonedDataTime
oxinabox
commented
Apr 14, 2021
| @test isbits(zdt) | ||
| else | ||
| @test_broken isbits(zdt) | ||
| end |
There was a problem hiding this comment.
this now reports only 1 broken (for VariableTimeZone)
since this includes the fix for FixedTimeZone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines #332
with #330
I am opening this PR not to be merged (since those to can be merged seperately)
but for testing purposes, and discussion of the approach.
This PR replaces
#324
It still doesn't solve #271 completely since it doesn't fix the Vector of transition in the VariableTimeZone