Merged
Conversation
Julow
approved these changes
Feb 25, 2026
Owner
Julow
left a comment
Julow
left a comment
There was a problem hiding this comment.
Thanks !
I've left some comments but if you prefer, I'm happy to merge it like this.
dzaima
force-pushed
the
slider-changes
branch
from
89d1cd9 to
0f174fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second commit is a general fix for sliders adding both axis movement to delta regardless of the current sliding direction (e.g. if you start sliding the horizontal space slider, but then move vertically, you get unexpected sideways movement). Especially confusing for a "joystick" key with all 4 sliders - if the initial slide is detected wrong, you start moving a lot but in an unexpected wrong direction. Also weird if you slide a bit off-axis.
Third commit is an opinionated change of slowing down horizontal sliding 4x while ctrl is held; intention being that for word selection (i.e what ctrl usually means) you want to be a lot more precise (also just balancing out a single movement being farther). I can remove it if it feels excessive.