Merged
Conversation
Started on manage event page. Looks just like the manage user roles page but of course with certain parameters changed. Filled slot and total slot information hardcoded for now.
Thanks to the ever so appreciated 2 P's in a Pod's commits, the search bar and filtering based off of events' startDate and endDate parameters have been implemented. Searching takes away any events not matching the exact wording. Sorting by Most Recent gives any events with a recent start date. Sorting by Oldest gives events that have the oldest start dates. Filtering by Past gives ONLY events that are older than the current date. Filtering by Upcoming ONLY shows events that have a start date past the current date. On another note, the Baselayout has been updated to call on our image buckets for the email pictures and now all emails will show the full Figma messaging. Some general changes were made but as of rn the removal, waitlist, and signed up emails can not be tested.
Lots of changes but finalized designs of both the table and the csv. The main table now has total capacity calculated all from site call just like regular table population, with dropdowns for every single event position in each. Also changed Upcoming to automatically sort any nearest upcoming event first rather than reversed. CSV now has event info plus signed up positions more compact. It now also automatically makes a zip folder whenever multiples events are saved as a CSV. To be able to call all of events positions per event I had to make new GET handlers so updated some routes.
…pediatrics into bcp-75-past-events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created Events Management page based on Volunteers management page (PP's ticket).
The event table functions similarly, with the ability to delete events and turn an event's info into a CSV file, with multiple events selected automatically becoming a zip folder containing each selected event CSV.
The search bar we changed because a dropdown for that made no sense (😐). The search bar will filter out info in the table as it is typing, too.
There are 4 filters/sorts: The default is on Most Recent, which sorts all events by nearest date. Oldest, which sorts by the oldest dates first. Upcoming, which completely filters out any events that are yet to happen. Lastly, Past filters out any events that have passed.
The main table also has dropdowns for every event that house each event positions capacity, and waitlist number. The total capacity for the event is calculated and displayed with/without the dropdown as well.
Issues
Resolve #75
Screenshots
Test
npx prisma generate
npm run dev
let it ride
Possible Downsides
My main gripe is that it's too slow in registering each event and each event position. Thankfully, we changed it to load it all at once rather than populate in real time, but it could be a bit faster.
There was also an issue with one event showing negative people, which was an issue the event admin table had, but we sort of clamped the values to not go below 0, so that's probably something to worry about.
The CSV right now doesn't have a waitlist section, but we were just following what @ava-sim told me to do.
Had to update GET handlers so that we can actually fetch per-event information, which might be making it slow, but that's above me at this point.
Doesn't search for like position names, but can be added in.
Additional Documentations
Nothing, Mina and I are like that.