Fix SerializedType dependency count on write #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the types from a version 21+ asset, UnityPy correctly reads the type tree, then correctly reads the list of dependencies as a regular "count + elements" array.
However, when writing the type tree, UnityPy writes a fixed 0x0 in place of the dependency array length, then writes the array without a count field (with
write_length
beingFalse
by default). This results a corrupted file when a type actually has dependencies.