MeshHandler - Implement reading m_StreamData
#290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0lb3
approved these changes
Jan 10, 2025
Owner
|
Thanks a lot 👍 |
Owner
|
I will do a version bump later today or tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like it's possible to read external data in UnityPy for a while now (https://github.com/K0lb3/UnityPy/blob/master/UnityPy/export/AudioClipConverter.py#L97) so I've also implemented it here.
Tested on some bundles that do contain meshes using
m_StreamDataand it does seem to work well. I can attach the said bundle files here if needed.This also addresses mos9527/sssekai_blender_io#15