Improve helpers module #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0lb3
reviewed
Feb 6, 2025
K0lb3
reviewed
Feb 6, 2025
K0lb3
reviewed
Feb 6, 2025
K0lb3
reviewed
Feb 6, 2025
K0lb3
force-pushed
the
master
branch
2 times, most recently
from
5ab6d25 to
c695346
Compare
isHarryh
force-pushed
the
patch-helpers
branch
from
46f2f13 to
2bb0dc1
Compare
Contributor
Author
|
According to your 4 reviews. I have changed these things and force-pushed these changes. |
K0lb3
reviewed
Feb 9, 2025
isHarryh
force-pushed
the
patch-helpers
branch
from
2bb0dc1 to
ac02d0c
Compare
isHarryh
force-pushed
the
patch-helpers
branch
from
ac02d0c to
f63ea1f
Compare
Contributor
Author
|
Okay. 2 fixes were applyed since the last push:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does some minor improvements on the helpers module. These improvements will not affect the existing features.
Common Changes
Individual Changes
ArchiveStorageDecryptor: Uses an inline approach to replace the functionto_uint4_array, which can improve the performance and simplify the code.ResourceReader: Refactors theget_resource_datafunction, because this function used an implicit argument overloading trick (mixed the 4-args invocation and the 3-args invocation, but only 4-args invocation is used externally), which is bad for maintaining.UnityVersion: Fixes the error in the methodfromString.