Skip to content

TypeTreeHelper - Add missing size argument in read_value_array #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
K0lb3 merged 2 commits into from
Feb 12, 2025
Merged

TypeTreeHelper - Add missing size argument in read_value_array #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb1ae02
Add missing `size` argument in `read_value_array`
mos9527 Feb 11, 2025
9b155b6
Fix typo in generated classes and `ClassesGenerator.py`
mos9527 Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UnityPy/classes/generated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def unitypy_define(cls: T) -> T:
which would make type-hinting more tricky, and breaks attrs.define.

Therefore this function bypasses the issue
by redifining the bases for problematic classes for the attrs.define call.
by redefining the bases for problematic classes for the attrs.define call.
"""
bases = cls.__bases__
if bases[0] in (object, Object, ABC):
Expand Down
6 changes: 4 additions & 2 deletions UnityPy/helpers/TypeTreeHelper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ def copy(self) -> TypeTreeConfig:
return TypeTreeConfig(self.as_dict, self.assetsfile, self.has_registry)


def get_ref_type_node(ref_object: dict, assetfile: SerializedFile) -> Optional[TypeTreeNode]:
def get_ref_type_node(
ref_object: dict, assetfile: SerializedFile
) -> Optional[TypeTreeNode]:
typ = ref_object["type"]
if isinstance(typ, dict):
cls = typ["class"]
Expand Down Expand Up @@ -209,7 +211,7 @@ def read_value(
size = reader.read_int()
subtype = node.m_Children[0].m_Children[1]
if metaflag_is_aligned(subtype.m_MetaFlag):
value = read_value_array(subtype, reader, config)
value = read_value_array(subtype, reader, config, size)
else:
value = [read_value(subtype, reader, config) for _ in range(size)]

Expand Down
2 changes: 1 addition & 1 deletion generators/ClassesGenerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def unitypy_define(cls: T) -> T:
which would make type-hinting more tricky, and breaks attrs.define.

Therefore this function bypasses the issue
by redifining the bases for problematic classes for the attrs.define call.
by redefining the bases for problematic classes for the attrs.define call.
\"\"\"
bases = cls.__bases__
if bases[0] in (object, Object, ABC):
Expand Down