use maps for compression and decompression functionality #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isHarryh
reviewed
Apr 9, 2025
K0lb3
force-pushed
the
maps-for-de/compression-functions
branch
from
5e8811a to
dca4055
Compare
isHarryh
reviewed
Apr 9, 2025
| ) | ||
| else: | ||
| return compressed_data | ||
| raise ValueError( |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
isHarryh
approved these changes
Apr 9, 2025
Contributor
isHarryh
left a comment
isHarryh
left a comment
There was a problem hiding this comment.
It worked well and is ready to merge.
Thanks a lot. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mapping layer for the compression and decompression functions used in BundleFile.
This layer makes it easier to use custom decompression methods for games that require it.
It solves #308