Open
Conversation
lievenhey
force-pushed
the
tracepoint-hover
branch
from
6b7e717 to
0bb88e0
Compare
lievenhey
force-pushed
the
tracepoint-hover
branch
3 times, most recently
from
a4eef75 to
f434e6d
Compare
milianw
requested changes
Jan 25, 2025
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
really great work @lievenhey and sorry for the overly long delay in reviewing. there are only a few minor things left from the code POV, I'll now look at the CI failure and also test-run it locally a bit
|
|
||
| #include "data.h" | ||
|
|
||
| class TracePointFormatter |
Collaborator
There was a problem hiding this comment.
only used by formatTracepoint, so this can move to the .cpp file (into an anon namespace there?)
Contributor
Author
There was a problem hiding this comment.
The Formatter is unit tested so I need that public access.
milianw
force-pushed
the
tracepoint-hover
branch
from
f434e6d to
5a6105a
Compare
Contributor
|
This looks nice. I do wonder (as I've not used tracepoints before) if it would be useful to provide a different (search-able list) as an alternative to the hover (that could be a separate PR, of course). Note: docs for the hover are missing. |
Open
The tracepoints are getting a better visual representation on the timelinewidget so this is no longer necessary.
Move the tracepoints from TimeAxisHeaderView to TimeLineWidget so that we can use the header for cpu usage. This also improves usability since the tracepoints are no longer bundles in one line. They now each have their own line.
Enum automatically counts up so there is no need to manually set these values.
this allows the user to group important timelines together so that he can compare them better
The favourites and tracepoint patches include some rows in the model that may be empty. To keep the code simple an readable all rows will be shown. Then a proxy model is put ontop to remove empty rows.
This way we can more easily find them and changing the sort order doesn't move them to the bottom.
Showing only one cost is fine if we only show a hardware event, but since we now support tracepoints and some come in an enter/exit pair it requires us to rework the timeline delegate. This patch makes the event source combobox multi select and allows to select multiple event sources.
lievenhey
force-pushed
the
tracepoint-hover
branch
8 times, most recently
from
146933f to
38c15a7
Compare
This patch allows hotspot to correctly parse most format string from the tracepoint definition. If that fails every entry in the tracepoint will be printed unformatted. In this case it is possible to add a custom formatter.
lievenhey
force-pushed
the
tracepoint-hover
branch
2 times, most recently
from
bb21870 to
d66c68d
Compare
lievenhey
force-pushed
the
tracepoint-hover
branch
from
d66c68d to
4158342
Compare
lievenhey
force-pushed
the
tracepoint-hover
branch
10 times, most recently
from
fe6a58b to
c80f53b
Compare
lievenhey
force-pushed
the
tracepoint-hover
branch
3 times, most recently
from
795d6d1 to
a02f515
Compare
lievenhey
force-pushed
the
tracepoint-hover
branch
from
a02f515 to
a7c66cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the tracepoint PR to show additional information when hovering over a tracepoint.
This requires the perfparser PR to be merged.
This is still wip. The following things are planned: