Open
Conversation
beingPracticer
requested review from
BuildTheTruth,
DongHyukki,
kkw01234,
mingimin,
minkukjo,
popcon9424,
yeojinhwang,
yuyu413 and
zozero94
minkukjo
reviewed
Aug 26, 2020
|
|
||
| public Board update(Long id, Board updateData) { | ||
| Board updatedBoard = repository.get(id); | ||
| if (updateData.content != null) updatedBoard.content = updateData.content; |
Member
There was a problem hiding this comment.
만약에 null check를 하셔야한다면 Optional을 써보시는건 어떨까요?
Member
|
올 언제하셨어요? |
kkw01234
approved these changes
Sep 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.