feat: Implement 'revoke' for Issuer
#930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
changed the title
IssuerIssuer
rflechtner
reviewed
Jan 15, 2025
Contributor
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
The docstrings need some love but otherwise I think this looks pretty damn good!
Co-authored-by: Raphael Flechtner <[email protected]>
rflechtner
reviewed
Jan 16, 2025
Contributor
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
Just a few nitpicks now, then we're done here 😬
rflechtner
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3646
replaces #918