styled the new contests page#183
Open
NikhilSharmaWe wants to merge 1 commit intoKamandPrompt:masterfrom
Open
Conversation
Member
|
@NikhilSharmaWe Thanks for working on this! It would be better if you attach some screenshots, in the PR itself. |
Signior-X
reviewed
Jan 20, 2021
Member
Signior-X
left a comment
There was a problem hiding this comment.
Good that you tried!
And you know how to write, just a better color scheme and look will be highly appreciated.
Looking for the changes soon!
| @@ -1,3 +1,4 @@ | |||
| import "./contests.css". | |||
Member
There was a problem hiding this comment.
You should not import any css in the models
This is just the mongodb model.
Also I think there no any contests.css so remove this from here.
| } | ||
|
|
||
|
|
||
| </style> |
Member
Member
There was a problem hiding this comment.
You can try to make it center and instead of using different colors, try using the same color scheme with different contrast.
Yellow somewhere blue somewhere brown doesn't look good.
I hope you get it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What's this PR do? (related issue if exists)
it styles the new contests page
Any context you want to provide on the implementation?
Screenshots? (necessary if an UI/UX change)