Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

The proxy servlet was not correctly handling HTTP redirects from the backend service. When the backend issued a redirect, the client's browser would be redirected to the backend URL, bypassing the proxy. This has been fixed by rewriting the Location header in redirect responses to ensure the client is always communicating with the proxy.


PR created automatically by Jules for task 17451618152518481817

The proxy was previously forwarding redirect responses from the target server to the client without modification. This caused the client to bypass the proxy and connect directly to the target server.

This change modifies the SimpleProxyServlet to intercept redirect responses and rewrite the Location header to point back to the proxy server. This ensures that all traffic remains routed through the proxy.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

The proxy was failing to handle dynamic URLs for 'apex/wwv_flow.ajax' because the 'contains' mapping type in web.xml was dropping query parameters. This has been changed to a 'prefix' mapping to correctly forward the entire URL, including dynamic parts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants