KeRNeLith · SpocWeb · Aug 3, 2024 · Aug 4, 2024 · Aug 4, 2024 · Aug 5, 2024
diff --git a/.editorconfig b/.editorconfig
@@ -1,12 +1,25 @@
+root = true
 # To learn more about .editorconfig see https://aka.ms/editorconfigdocs
 
 ###############################
 # Core EditorConfig Options   #
 ###############################
-root = true
 # All files
 [*]
 indent_style = space
+
+# Microsoft .NET properties
+csharp_style_var_elsewhere = false:suggestion
+csharp_style_var_for_built_in_types = false:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+
+# ReSharper properties
+resharper_use_roslyn_logic_for_evident_types = false
+
+# ReSharper inspection severities
+resharper_suggest_var_or_type_built_in_types_highlighting = hint
+resharper_suggest_var_or_type_elsewhere_highlighting = hint
+resharper_suggest_var_or_type_simple_types_highlighting = hint
 # Code files
 [*.{h,hpp,inl,c,cpp,cs,csx,vb,vbx}]
 indent_size = 4
@@ -53,14 +66,14 @@ dotnet_style_prefer_conditional_expression_over_return = true:silent
 # Naming Conventions          #
 ###############################
 # Style Definitions
-dotnet_naming_style.pascal_case_style.capitalization             = pascal_case
+dotnet_naming_style.pascal_case_style.capitalization = pascal_case
 # Use PascalCase for constant fields  
 dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
-dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols  = constant_fields
-dotnet_naming_rule.constant_fields_should_be_pascal_case.style    = pascal_case_style
-dotnet_naming_symbols.constant_fields.applicable_kinds            = field
-dotnet_naming_symbols.constant_fields.applicable_accessibilities  = *
-dotnet_naming_symbols.constant_fields.required_modifiers          = const
+dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
+dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
+dotnet_naming_symbols.constant_fields.applicable_kinds = field
+dotnet_naming_symbols.constant_fields.applicable_accessibilities = *
+dotnet_naming_symbols.constant_fields.required_modifiers = const
 
 ###############################
 # C# Coding Conventions       #
@@ -121,4 +134,4 @@ csharp_space_between_method_call_name_and_opening_parenthesis = false
 csharp_space_between_method_call_empty_parameter_list_parentheses = false
 # Wrapping preferences
 csharp_preserve_single_line_statements = true
-csharp_preserve_single_line_blocks = true
+csharp_preserve_single_line_blocks = true
diff --git a/.gitignore b/.gitignore
@@ -15,6 +15,7 @@ src/DotParser/res.dot
 *.user
 *.userosscache
 *.sln.docstates
+.obsidian
 
 # Build results
 [Dd]ebug/

diff --git a/QuikGraph.sln b/QuikGraph.sln
@@ -1,6 +1,6 @@
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 16
-VisualStudioVersion = 16.0.30011.22
+# Visual Studio Version 17
+VisualStudioVersion = 17.11.35208.52
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Misc", "Misc", "{FAAD5B1C-1217-48D6-B1EF-7CAC0440D6A4}"
 	ProjectSection(SolutionItems) = preProject
@@ -44,14 +44,6 @@ EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "QuikGraph.Petri.Tests", "tests\QuikGraph.Petri.Tests\QuikGraph.Petri.Tests.csproj", "{CD993F58-A275-4E67-9F8E-BAF3BE6F21B6}"
 EndProject
 Global
-	GlobalSection(SharedMSBuildProjectFiles) = preSolution
-		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{69dfd21c-d3a3-4764-b3f0-2fdf612e1f65}*SharedItemsImports = 5
-		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{908fe868-7abe-4fe8-bfa6-c5e6572b780d}*SharedItemsImports = 5
-		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{7160ddab-12b0-491f-9a79-bf3b5e0cd872}*SharedItemsImports = 5
-		tests\QuikGraph.Serialization.Tests.CommonInternals\QuikGraph.Serialization.Tests.CommonInternals.projitems*{61df76e1-de2b-4df1-ad5f-89939ab06693}*SharedItemsImports = 5
-		tests\QuikGraph.Serialization.Tests.CommonInternals\QuikGraph.Serialization.Tests.CommonInternals.projitems*{8adddae1-fa2c-4637-c67f-8743beb126cd}*SharedItemsImports = 5
-		tests\QuikGraph.Serialization.Tests.CommonInternals\QuikGraph.Serialization.Tests.CommonInternals.projitems*{98e60a67-c326-4b83-8eff-b77e9c651945}*SharedItemsImports = 13
-	EndGlobalSection
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
 		Release|Any CPU = Release|Any CPU
@@ -129,4 +121,27 @@ Global
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {C26EFBC1-5149-4422-AFD3-172667AA018F}
 	EndGlobalSection
+	GlobalSection(SharedMSBuildProjectFiles) = preSolution
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{1c978139-80bd-4081-94cc-14cbaeefeb24}*SharedItemsImports = 5
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{20713f1d-74e0-44e0-a533-0d3dc30d3898}*SharedItemsImports = 5
+		tests\QuikGraph.Tests.CommonInternals\QuikGraph.Tests.CommonInternals.projitems*{52f3ffcf-1638-48d8-b124-0347c723f2fc}*SharedItemsImports = 13
+		tests\QuikGraph.Serialization.Tests.CommonInternals\QuikGraph.Serialization.Tests.CommonInternals.projitems*{61df76e1-de2b-4df1-ad5f-89939ab06693}*SharedItemsImports = 5
+		tests\QuikGraph.Tests.CommonInternals\QuikGraph.Tests.CommonInternals.projitems*{61df76e1-de2b-4df1-ad5f-89939ab06693}*SharedItemsImports = 5
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{69dfd21c-d3a3-4764-b3f0-2fdf612e1f65}*SharedItemsImports = 5
+		tests\QuikGraph.Tests.CommonInternals\QuikGraph.Tests.CommonInternals.projitems*{69dfd21c-d3a3-4764-b3f0-2fdf612e1f65}*SharedItemsImports = 5
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{7160ddab-12b0-491f-9a79-bf3b5e0cd872}*SharedItemsImports = 5
+		tests\QuikGraph.Tests.CommonInternals\QuikGraph.Tests.CommonInternals.projitems*{7160ddab-12b0-491f-9a79-bf3b5e0cd872}*SharedItemsImports = 5
+		tests\QuikGraph.Serialization.Tests.CommonInternals\QuikGraph.Serialization.Tests.CommonInternals.projitems*{8adddae1-fa2c-4637-c67f-8743beb126cd}*SharedItemsImports = 5
+		tests\QuikGraph.Tests.CommonInternals\QuikGraph.Tests.CommonInternals.projitems*{8adddae1-fa2c-4637-c67f-8743beb126cd}*SharedItemsImports = 5
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{908fe868-7abe-4fe8-bfa6-c5e6572b780d}*SharedItemsImports = 5
+		tests\QuikGraph.Tests.CommonInternals\QuikGraph.Tests.CommonInternals.projitems*{908fe868-7abe-4fe8-bfa6-c5e6572b780d}*SharedItemsImports = 5
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{90e1536b-6b95-4072-8c60-10e4dc30ae1a}*SharedItemsImports = 5
+		tests\QuikGraph.Serialization.Tests.CommonInternals\QuikGraph.Serialization.Tests.CommonInternals.projitems*{98e60a67-c326-4b83-8eff-b77e9c651945}*SharedItemsImports = 13
+		tests\QuikGraph.Tests.CommonInternals\QuikGraph.Tests.CommonInternals.projitems*{98e60a67-c326-4b83-8eff-b77e9c651945}*SharedItemsImports = 13
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{a9a5c115-0680-44b3-a87e-5ecf4c93814e}*SharedItemsImports = 5
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{c8b5e125-4624-44d9-1234-5caf4c25876e}*SharedItemsImports = 5
+		tests\QuikGraph.Tests.CommonInternals\QuikGraph.Tests.CommonInternals.projitems*{cd993f58-a275-4e67-9f8e-baf3be6f21b6}*SharedItemsImports = 5
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{ce984360-54f0-406f-b8a9-e75897daed3b}*SharedItemsImports = 13
+		src\QuikGraph.CommonInternals\QuikGraph.CommonInternals.projitems*{f7008baf-1f3a-4406-80b1-4a2f2cdc0cdd}*SharedItemsImports = 5
+	EndGlobalSection
 EndGlobal
diff --git a/QuikGraph.sln.DotSettings b/QuikGraph.sln.DotSettings
@@ -1,4 +1,5 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeVarKeywordsInDeconstructingDeclaration/@EntryIndexedValue">HINT</s:String>
     <!-- Style Cop https://github.com/Visual-Stylecop/Visual-StyleCop/wiki -->
 
     <!-- PrefixLocalCallsWithThis -->
@@ -64,5 +65,8 @@
     <s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=URI/@EntryIndexedValue">URI</s:String>
     <s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=US/@EntryIndexedValue">US</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateInstanceFields/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="_" Suffix="" Style="aaBb" /&gt;</s:String>
+	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=4a98fdf6_002D7d98_002D4f5a_002Dafeb_002Dea44ad98c70c/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Instance" AccessRightKinds="Private" Description="Instance fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="FIELD" /&gt;&lt;Kind Name="READONLY_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" Prefix="_" Suffix="" Style="aaBb" /&gt;&lt;/Policy&gt;</s:String>
+	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EPredefinedNamingRulesToUserRulesUpgrade/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Eulerian/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Quik/@EntryIndexedValue">True</s:Boolean>
 </wpf:ResourceDictionary>
diff --git a/README.md b/README.md
@@ -1,34 +1,40 @@
-| | |
-| --- | --- |
-| **Build** | [![AppVeyor Build Status](https://ci.appveyor.com/api/projects/status/github/KeRNeLith/QuikGraph?branch=master&svg=true)](https://ci.appveyor.com/project/KeRNeLith/quikgraph) |
-| **Coverage** | <sup>Coveralls</sup> [![Coverage Status](https://coveralls.io/repos/github/KeRNeLith/QuikGraph/badge.svg?branch=master)](https://coveralls.io/github/KeRNeLith/QuikGraph?branch=master) <sup>SonarQube</sup> [![SonarCloud Coverage](https://sonarcloud.io/api/project_badges/measure?project=quikgraph&metric=coverage)](https://sonarcloud.io/component_measures/metric/coverage/list?id=quikgraph) | 
-| **Quality** | [![Quality Gate](https://sonarcloud.io/api/project_badges/measure?project=quikgraph&metric=alert_status)](https://sonarcloud.io/dashboard?id=quikgraph) | 
-| **Nugets** | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.svg)](https://www.nuget.org/packages/QuikGraph) QuikGraph |
-| | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.serialization.svg)](https://www.nuget.org/packages/QuikGraph.Serialization) QuikGraph.Serialization |
-| | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.graphviz.svg)](https://www.nuget.org/packages/QuikGraph.Graphviz) QuikGraph.Graphviz |
-| | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.data.svg)](https://www.nuget.org/packages/QuikGraph.Data) QuikGraph.Data |
-| | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.msagl.svg)](https://www.nuget.org/packages/QuikGraph.MSAGL) QuikGraph.MSAGL |
-| | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.petri.svg)](https://www.nuget.org/packages/QuikGraph.Petri) QuikGraph.Petri |
-| **License** | MS-PL |
+|              |                                                                                                                                                                                                                                                                                                                                                                                                       |     |
+| ------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --- |
+| **Build**    | [![AppVeyor Build Status](https://ci.appveyor.com/api/projects/status/github/KeRNeLith/QuikGraph?branch=master&svg=true)](https://ci.appveyor.com/project/KeRNeLith/quikgraph)                                                                                                                                                                                                                        |     |
+| **Coverage** | <sup>Coveralls</sup> [![Coverage Status](https://coveralls.io/repos/github/KeRNeLith/QuikGraph/badge.svg?branch=master)](https://coveralls.io/github/KeRNeLith/QuikGraph?branch=master) <sup>SonarQube</sup> [![SonarCloud Coverage](https://sonarcloud.io/api/project_badges/measure?project=quikgraph&metric=coverage)](https://sonarcloud.io/component_measures/metric/coverage/list?id=quikgraph) |     |
+| **Quality**  | [![Quality Gate](https://sonarcloud.io/api/project_badges/measure?project=quikgraph&metric=alert_status)](https://sonarcloud.io/dashboard?id=quikgraph)                                                                                                                                                                                                                                               |     |
+| **Nugets**   | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.svg)](https://www.nuget.org/packages/QuikGraph) QuikGraph                                                                                                                                                                                                                                                                                   |     |
+|              | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.serialization.svg)](https://www.nuget.org/packages/QuikGraph.Serialization) QuikGraph.Serialization                                                                                                                                                                                                                                         |     |
+|              | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.graphviz.svg)](https://www.nuget.org/packages/QuikGraph.Graphviz) QuikGraph.Graphviz                                                                                                                                                                                                                                                        |     |
+|              | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.data.svg)](https://www.nuget.org/packages/QuikGraph.Data) QuikGraph.Data                                                                                                                                                                                                                                                                    |     |
+|              | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.msagl.svg)](https://www.nuget.org/packages/QuikGraph.MSAGL) QuikGraph.MSAGL                                                                                                                                                                                                                                                                 |     |
+|              | [![Nuget Status](https://img.shields.io/nuget/v/quikgraph.petri.svg)](https://www.nuget.org/packages/QuikGraph.Petri) QuikGraph.Petri                                                                                                                                                                                                                                                                 |     |
+| **License**  | MS-PL                                                                                                                                                                                                                                                                                                                                                                                                 |     |
 
 # QuikGraph
 
 ## What is **QuikGraph**?
 
 QuikGraph provides generic directed/undirected graph data structures and algorithms for .NET.
 
-QuikGraph comes with algorithms such as depth first search, breath first search, A* search, shortest path, k-shortest path, maximum flow, minimum spanning tree, etc.
+QuikGraph comes with algorithms such as depth first search, breath first search, A* search, 
+shortest path, k-shortest path, maximum flow, minimum spanning tree, etc.
 
 *QuikGraph was originally created by Jonathan "Peli" de Halleux in 2003 and named QuickGraph.*
 
 It was then updated to become YC.QuickGraph.
 
-**This version** of QuickGraph, renamed **QuikGraph**, is a fork of YC.QuickGraph, and I tried to clean the library to provide it as a clean NuGet packages using modern C# development (.NET Core).
+**This version** of QuickGraph, renamed **QuikGraph**, is a fork of YC.QuickGraph, 
+and I tried to clean the library to provide it as a clean NuGet packages using modern C# development (.NET Core).
 
-The library has been cleaned and improved. It comes with a lot of fixes for issues of the original library. It also has a wide support of .NET targets to make it compatible with the most development environments.
+The library has been cleaned and improved. It comes with a lot of fixes for issues of the original library. 
+It also has a wide support of .NET targets to make it compatible with the most development environments.
 
 **[Getting started with QuikGraph](https://github.com/KeRNeLith/QuikGraph/wiki)**
 
+Detailed Information can be found in the Library [[src/QuikGraph/ReadMe|ReadMe]] 
+and the NDoc of the individual Algorithms.
+
 ---
 
 ## Targets

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,5 +1,16 @@
 # Release notes
 
+## What's new in 3.0.0 2024-08-18
+
+### QuikGraph: allowing for CoVariance
+* using `Edge.Create(source, target)` instead of `new Edge(source, target)`
+* deprecated `TryGet...` Methods in favor of nullable Results: 
+  * `IEnumerable<T>` was made nullable to indicate an unknown Vertex Argument.
+  * `Edge<T>` was made nullable to indicate an unknown Vertex Argument.
+* using `IEdge{T}` instead of `Edge{T}` to be more flexible. 
+* The downside is that structs like `SEdge` will be boxed now, which may reduce Efficiency. 
+
+
 ## What's new in 2.5.0 July 4 2022
 
 ### QuikGraph

diff --git a/appveyor.yml b/appveyor.yml
@@ -41,6 +41,7 @@ environment:
 # Setup build version
 install:
   - ps: ./build/setupBuild.ps1
+  - ps: choco install docfx -y
 
 # Assembly infos & csproj patching
 assembly_info:
@@ -89,7 +90,7 @@ build_script:
 # Start SonarQube analysis (only for Release configuration)
   - ps: $analysisFile = (Convert-Path SonarQube.Analysis.xml).ToString()
   - ps: >-
-      if ($env:IsFullIntegrationBuild -eq $true)
+      if ($env:IsFullIntegrationBuild -eq $NULL)
       {
           & $sonarScanner begin /k:"quikgraph" /s:$analysisFile /o:"kernelith-github" /d:sonar.host.url="https://sonarcloud.io" /d:"sonar.branch.name=$env:APPVEYOR_REPO_BRANCH" /d:sonar.cs.opencover.reportsPaths="coverage.xml" /d:sonar.login="$env:SONARQUBE_TOKEN"
       }
@@ -122,7 +123,7 @@ test_script:
       $testAssemblies = (ls tests\*.Tests\bin\$env:Configuration\net461\*Tests.dll | Where-Object { $_ -Match "net*" -and $_ -NotMatch "netcoreapp*" -and [System.IO.Path]::GetFileNameWithoutExtension($_.FullName) -Match $_.Directory.Parent.Parent.Parent.Name } | % FullName | sort-object -Unique);
 
       $testsPassed = $false;
-      if ($env:IsFullIntegrationBuild -eq $true)
+      if ($env:IsFullIntegrationBuild -eq $NULL)
       {
           $opencover = (Resolve-Path "tools\OpenCover.*\tools\OpenCover.Console.exe").ToString();
           $coveralls = (Resolve-Path "tools\csmacnz.Coveralls.exe").ToString();
@@ -143,7 +144,7 @@ test_script:
       # Upload results to AppVeyor
 
       $wc = New-Object 'System.Net.WebClient';
-      $wc.UploadFile("https://ci.appveyor.com/api/testresults/nunit3/$($env:APPVEYOR_JOB_ID)", (Resolve-Path .\TestResult.xml));
+      #$wc.UploadFile("https://ci.appveyor.com/api/testresults/nunit3/$($env:APPVEYOR_JOB_ID)", (Resolve-Path .\TestResult.xml));
 
       if (!$testsPassed)
       {