make globs an optional feature #498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no warnings reported
jakeswenson
approved these changes
May 31, 2020
| if parent_dir.starts_with("./") { | ||
| parent_dir = &parent_dir[2..]; | ||
| } | ||
| #[cfg(feature = "globs")] |
Contributor
There was a problem hiding this comment.
This is a subtle change in behavior that caught me off guard at first. I thought this was a behavioral breaking change at first, but then i realized that you've made globs a default feature, so it's subtly not a breaking change. 👍
Owner
There was a problem hiding this comment.
It is a breaking change for anyone using default-features=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #484. It makes globwalk optional. It reduced the build time, but not the wasm size, which was my main goal.