Fix: Prevent duplicate JS bridge injection on desktop #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaroxh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On desktop, CEF triggers multiple loadingState changes (for the main frame and again for DevTools or iFrames). Each change currently reinjects the JS bridge, which resets the callbacks map & callbackId. If a callback is pending during reinjection, it’s lost and never resolves.
This change ensures the bridge is injected only once per page context by checking whether it already exists before injecting. This prevents callback resets while preserving expected behavior across main content, DevTools, and iFrames.