Update actions/gerald-pr to use Khan/gerald@v5.1 so that we use Node v24 everywhere#157
Merged
kevinb-khan merged 2 commits intomainfrom Mar 31, 2026
Merged
Update actions/gerald-pr to use Khan/gerald@v5.1 so that we use Node v24 everywhere#157kevinb-khan merged 2 commits intomainfrom
kevinb-khan merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: e948429 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
khan-actions-bot
requested review from
a team,
jaredly and
jeresig
and removed request for
a team
Contributor
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jeresig
approved these changes
Mar 31, 2026
kevinb-khan
added a commit
to Khan/gerald
that referenced
this pull request
Mar 31, 2026
🖍 _This is an audit!_ 🖍 ## Summary: This is part of ongoing work to update all of our GitHub actions to be using Node v24. I missed that ./action.yml specified which version of Node it was using. Issue: None ## Test plan: - after landing this PR, tag the commit with v5.1 - update Khan/actions#157 to use v5.1 of Khan/gerald - see that there are no warnings about Node v20 being used by Khan/gerald Author: kevinb-khan Pull Request URL: #101
kevinb-khan
changed the title
kevinb-khan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In Khan/gerald#100, I update the third-party actions that Khan/gerald's uses to versions that use Node v24 (instead of v20). This PR updates the actions wrapper in this repo to use the new version of that action.
Issue: FEI-7601
Test plan:
I retried Gerald a few times because it looked like it wasn't running, that's why there are three reports. One the plus side, none of them show warnings about Node v20. Here's a link to one of the runs to show that it actually did run: https://github.com/Khan/actions/actions/runs/23815675785/job/69414414986.