Open
Conversation
franz
force-pushed
the
mutable_dispatch_fixes
branch
from
c26f9eb to
2cdd0eb
Compare
EwanC
requested changes
Nov 8, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_fill.cpp
Outdated
Show resolved
Hide resolved
…heck the test checks 'cl_khr_extended_versioning' then immediately calls: get_extension_version(device, "cl_khr_command_buffer_mutable_dispatch"); .. however, get_extension_version throws an exception when called with unsupported extension.
the test uses CL_MUTABLE_DISPATCH_ARGUMENTS_KHR, but does not check for support.
test MutableDispatchGlobalSize was failing (with an implementation that doesn't support non-uniform WGs), because the update_global_size = 3 was not a multiple of the local work-size. Fixed by increasing the global work-size to 256K and update size to 16K. This should work with all devices that have max_work_group_size <= 16K. Updates also MutableDispatchWorkGroups which had an out-of-bounds access, because it hardcoded the value of global work-size.
franz
force-pushed
the
mutable_dispatch_fixes
branch
from
2cdd0eb to
a2fc5d8
Compare
EwanC
reviewed
Jan 8, 2025
Contributor
There was a problem hiding this comment.
Sorry it's taken me a while to re-review this.
My main thought from looking at this again is whether we need to be using as many as 256K and 16K work items for the test, which is quite a big increase on what we had before. I'm not sure if on embedded devices or simulators that would slow the test time down and not really give us that much extra testing coverage of the extension. Could we use work item sizes that are an order of magnitude less but still resolve the issues you've seen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.