Open
Conversation
Add tests for clEnqueueMapBuffer and clEnqueueUnmapMemObject with a buffer created using a AHardwareBuffer Signed-off-by: Alex Davicenko <alex.davicenko@arm.com>
joselopeqti
requested changes
Jan 28, 2026
| void *mapped_ptr = | ||
| clEnqueueMapBuffer(queue, buffer, CL_BLOCKING, CL_MAP_READ, 0, | ||
| buffer_size, 0, nullptr, nullptr, &err); | ||
| test_error(err, "clEnqueueMapBuffer failed"); |
Collaborator
There was a problem hiding this comment.
I just noticed that clEnqueueAcquireExternalMemObjectsKHR and clEnqueueReleaseExternalMemObjectsKHR are missing in this test and in lifetime_buffer, lifetime_image and sub_buffer.
They need to be called to comply with the spec:
Applications must acquire the memory objects that are created using external handles before they can be used by any OpenCL commands queued to a command-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for clEnqueueMapBuffer and clEnqueueUnmapMemObject with a buffer created using a AHardwareBuffer