Fix test_vulkan_interop_buffer/image validation errors for illegal memory type selection on AMD/RADV#2620
Open
shajder wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
…ypes at logical device level VulkanDevice now owns a filtered memory type list excluding types whose features were not enabled at device creation. VulkanImage and VulkanBuffer updated to use VulkanDevice::getMemoryTypeList() instead of the unfiltered physical device list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2491
@karolherbst I don't have an AMD device to test with, I would appreciate extra caution on this one, thanks!
VulkanDevice now builds its own memory type list from the physical device's list, excluding types whose required features were not enabled at device creation time.