Open
Conversation
…ion if test fails in the second subtest
lakshmih
approved these changes
Mar 10, 2026
lakshmih
reviewed
Mar 10, 2026
Contributor
lakshmih
left a comment
lakshmih
left a comment
There was a problem hiding this comment.
It isn't clear what additional coverage this is adding or why so would like that clarification
lakshmih
requested changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the second subtest, map streams[0] (created with input_ptr as CL_MEM_USE_HOST_PTR]) before modifying its host_ptr.
Set err to error_count at the end of the test, otherwise if the second subtest fails, it will print the last one failed too.
Rest of changes is formatting.