move cluster size restrictions for cl_khr_subgroup_clustered_reduce#1535
Open
bashbaug wants to merge 2 commits intoKhronosGroup:mainfrom
Open
move cluster size restrictions for cl_khr_subgroup_clustered_reduce#1535bashbaug wants to merge 2 commits intoKhronosGroup:mainfrom
bashbaug wants to merge 2 commits intoKhronosGroup:mainfrom
Conversation
Instead of documenting cluster size restrictions in the section header, describe the restrictions in the description for each of the functions. This aligns with the way cluster size restrictions are documented for cl_khr_subgroup_rotate and makes the restriction easier to spot.
Contributor
|
Mhh looks good. I just wonder if we want to converge the wording, because for rotate it says "clustersize must be an integer constant expression and a power of two, smaller than or equal to the maximum sub-group size, otherwise the behavior is undefined." Picking either wording, or leaving it as is is fine with me. |
Contributor
Author
Sure, that's easy enough to do. I've gone with the clustered reduce wording for now instead of the rotate wording because we usually use "must" to describe conditions that are statically checked (or at least, checkable), and that isn't the case for any of these conditions. CC @kpet for awareness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1534
Instead of documenting cluster size restrictions in the section header, describe the restrictions in the description for each of the functions. This aligns with the way cluster size restrictions are documented for cl_khr_subgroup_rotate and makes the restriction easier to spot.