Conversation
|
(I don't know what magic @illuhad have done, but I cannot add him as a reviewer... Smart guy!) |
gmlueck
left a comment
There was a problem hiding this comment.
LGTM!
Do we need to change the CTS to pass a const pointer to these APIs?
Oh yes good idea; it should make the CST fail with an implementation implementing the old specification. Not sure, if it's a blocking change but should be better indeed. |
illuhad
left a comment
There was a problem hiding this comment.
LGTM!
@TApplencourt I think github only allows requesting reviews from people who have write permissions, which, for whatever reason, I don't have for SYCL-Docs. That's also why my review checkmarks are not green either.
I think it is because you were not part of the sycl-committee group. I just invited you, and it looks like you are a member now. |
|
Yep, thanks @gmlueck :-) |
|
WG: Merge as clarification. |
Fix #963
Implementation are correct, spec should follow : )