Skip to content

Add const to prefetch and memadvice#987

Open
TApplencourt wants to merge 1 commit intomainfrom
const_prefetch
Open

Add const to prefetch and memadvice#987
TApplencourt wants to merge 1 commit intomainfrom
const_prefetch

Conversation

@TApplencourt
Copy link
Contributor

Fix #963

Implementation are correct, spec should follow : )

@TApplencourt
Copy link
Contributor Author

(I don't know what magic @illuhad have done, but I cannot add him as a reviewer... Smart guy!)

Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Do we need to change the CTS to pass a const pointer to these APIs?

@TApplencourt
Copy link
Contributor Author

Do we need to change the CTS to pass a const pointer to these APIs?

Oh yes good idea; it should make the CST fail with an implementation implementing the old specification.

Not sure, if it's a blocking change but should be better indeed.

Copy link
Contributor

@illuhad illuhad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TApplencourt I think github only allows requesting reviews from people who have write permissions, which, for whatever reason, I don't have for SYCL-Docs. That's also why my review checkmarks are not green either.

@gmlueck
Copy link
Contributor

gmlueck commented Mar 12, 2026

I think github only allows requesting reviews from people who have write permissions, which, for whatever reason, I don't have for SYCL-Docs. That's also why my review checkmarks are not green either.

I think it is because you were not part of the sycl-committee group. I just invited you, and it looks like you are a member now.

@illuhad
Copy link
Contributor

illuhad commented Mar 12, 2026

Yep, thanks @gmlueck :-)

@TApplencourt
Copy link
Contributor Author

WG: Merge as clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefetch/ Memadvice should be const

3 participants