Skip to content

GPU-AV: Add a root node to access validation buffers through pointers #10551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GPU-AV: Add a root node to access validation buffers through pointers #10551

wants to merge 1 commit into from

Conversation

arno-lunarg
Copy link
Contributor

No description provided.

@arno-lunarg arno-lunarg requested a review from a team as a code owner August 19, 2025 15:18
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 512626.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20835 running.

spencer-lunarg
spencer-lunarg reviewed Aug 19, 2025
View reviewed changes
layers/gpuav/core/gpuav_setup.cpp Outdated
indices_buffer_alignment_ =
sizeof(uint32_t) *
static_cast<uint32_t>(
phys_dev_props.limits.minStorageBufferOffsetAlignment); // #ARNO_TODO need to find correct alignment, we align
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking into now myself, also nit, add comment above line so clang-format doesn't go crazy here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in the end, this alignment can be whatever I want, as long as the buffer_reference_align in the corresponding shader buffer is respected?

spencer-lunarg
spencer-lunarg reviewed Aug 19, 2025
View reviewed changes
layers/gpuav/instrumentation/gpuav_instrumentation.cpp Outdated
wds.pBufferInfo = &dbi;

DispatchUpdateDescriptorSets(gpuav.device, 1, &wds, 0, nullptr);
#if 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove before we merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

spencer-lunarg
spencer-lunarg reviewed Aug 19, 2025
View reviewed changes
layers/gpuav/shaders/gpuav_shaders_constants.h Outdated
const int kBindingInstCmdResourceIndex = 6;
const int kBindingInstCmdErrorsCount = 7;
const int kBindingInstVertexAttributeFetchLimits = 8;
// #ARNO_TODO will be 0, once I get rid of validation pipeline specific descriptor set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"will be zero" but it is zero... not sure what you mean here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old stuff

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20835 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 512754.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20839 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20839 failed.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from 579d72d to 18c91ad Compare August 20, 2025 09:48
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 513108.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20844 running.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from 18c91ad to 411c2fc Compare August 20, 2025 09:50
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 513124.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from 411c2fc to 45564c5 Compare August 20, 2025 09:52
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 513139.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20846 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20846 failed.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from 45564c5 to 02b1088 Compare August 20, 2025 12:42
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 513248.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20848 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20848 failed.

@spencer-lunarg spencer-lunarg mentioned this pull request Aug 24, 2025
Closed
@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from 02b1088 to c1cd997 Compare August 26, 2025 09:29
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 517357.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20895 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20895 failed.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from c1cd997 to 06e29b4 Compare August 28, 2025 17:17
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 519918.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20920 running.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from 06e29b4 to 920e9c0 Compare August 28, 2025 17:54
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 519955.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20921 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20921 failed.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from 920e9c0 to 7ff0ceb Compare August 28, 2025 19:24
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 520037.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20923 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20923 failed.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from 7ff0ceb to f4577b9 Compare August 29, 2025 07:08
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 520395.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20929 running.

@arno-lunarg
gpuav: Add a root node
69e2186 
First step toward removing usage of descriptor sets in GPU-AV
Have a "root node" buffer, accessed through its address,
and itself pointing to the various buffers needed to perform
validation.
@arno-lunarg arno-lunarg force-pushed the arno-gpuav-root-node-v2 branch from f4577b9 to 69e2186 Compare August 29, 2025 07:41
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 520436.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20930 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 20930 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arno-lunarg @ci-tester-lunarg @spencer-lunarg