Add checks to coopMatMulAdd #4022
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate properties of coopMatMulAdd such as: * the inside dimension of the multiplication matrices must match * the dimension of the addition matrix must match the product of the multiplication * the usage property of all operands must match the expected value
|
@mmoult You probably want to take a look at the test failures that CI is reporting here. You will also want to add a test that triggers these new error checks, for example in |
tests under the SPV 1.4 semantics
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.9 to 3.29.11. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@df55935...3c3833e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.29.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
In SPIR-V specification `SPV_KHR_cooperative_matrix`, allows the `use` of cooperative matrix is a constant instruction. The use in this context is: how to use the matrix as matrixA, matrixB or matrixAccumulate. gl_MatrixUse* are constant integer values which can be used for the MatrixUse template parameter in cooperative matrix types.
This fixes KhronosGroup#4018 Capability names do not include the "Capability" prefix, but some capabilities where being labeled with it. This PR addresses the inconsistency. Tests adjusted to match the new labels.
…Group#3962) * Prevent null fieldName access. * Add test for unnamed parameter fix. * Update validation_fails.txt
Nvidia cooperative matrices have slightly different type parameters. Handle this variant properly in the MatMulAdd checks.
|
@arcady-lunarg I think this is ready for review. My rebase didn't cleanly handle my three commits on top of main, but you can easily see my changes with: |
|
Would you like me to make a fresh pull request with the same content (but without the bad rebase)? Would that help? I am a little surprised I haven't gotten any feedback for nearly 3 weeks. I was able to resolve the CI failures and I added a new test that triggers my checks, just as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate properties of coopMatMulAdd such as:
multiplication