Skip to content

Fixing glslang bin build with MinGW. #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixing glslang bin build with MinGW. #4032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
319c2ae
Fixing glslang bin build with MinGW.
Sendan4 Sep 3, 2025
522e019
Fix CI errors and make the change case especific
Sendan4 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,11 @@ function(glslang_only_export_explicit_symbols target)
set_target_properties(${target} PROPERTIES CXX_VISIBILITY_PRESET hidden)
set_target_properties(${target} PROPERTIES C_VISIBILITY_PRESET hidden)
if(WIN32)
target_compile_definitions(${target} PRIVATE "GLSLANG_EXPORTING=1")
if(${CMAKE_CXX_COMPILER_ID} MATCHES "GNU")
target_compile_definitions(${target} PUBLIC "GLSLANG_EXPORTING=1")
else()
target_compile_definitions(${target} PRIVATE "GLSLANG_EXPORTING=1")
endif()
endif()
endif()
endfunction()
Expand Down