Skip to content

Add Ty type checking [awaiting Ty beta] #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Add Ty type checking [awaiting Ty beta] #458

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ebae7e9
Initial move from pyright to ty!
scosman Jun 20, 2025
f060416
Merge branch 'main' into scosman/ty-typechecking
scosman Jul 25, 2025
0122cc4
Upgrade ty, it supports enums now!
scosman Jul 25, 2025
dee71eb
Replace our custom exhaustive check with more idomatic assert_never, …
scosman Jul 25, 2025
925696c
Fix tests
scosman Jul 25, 2025
6e0cd30
Move the casting up to where the problem starts. Work around for
scosman Jul 25, 2025
dc1fc2a
Fix some
scosman Jul 25, 2025
9468a0c
Fix more type errors
scosman Jul 25, 2025
f5918b1
Fix type error
scosman Jul 25, 2025
2167038
Fix type error (old was okay, but ty didn't like it)
scosman Jul 25, 2025
0e1351f
Fix type error
scosman Jul 25, 2025
74e4689
Fix last of type errors for ty!
scosman Jul 25, 2025
9572523
Update suggested extensions
scosman Jul 25, 2025
115caba
Add type checking to our fast CI since it's now fast!
scosman Jul 25, 2025
b4950a2
install ty
scosman Jul 25, 2025
505a010
Install latest
scosman Jul 25, 2025
9bb9a2a
Install project for type checking
scosman Jul 25, 2025
2b06ed1
Merge branch 'main' into scosman/ty-typechecking
scosman Jul 25, 2025
c467c02
Update settings: disable pylance/basedpyright language server in favo…
scosman Jul 29, 2025
6953f6e
CR feedback
scosman Jul 29, 2025
52f83de
Fix JSON formatting
scosman Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: uv run python3 -m pytest .

- name: Check Python Types
run: uv run pyright .
run: uvx ty check

- name: Build Core
run: uv build
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ uvx ruff check --select I
# Formatting 2:
uvx ruff format --check .
# type checking: warnings in output are acceptable, but error codes are not
uv run pyright .
uvx ty check
# tests:
uv run python3 -m pytest --benchmark-quiet -q .
```
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ We suggest the following extensions for VSCode/Cursor. With them, you'll get com
- Prettier
- Python
- Python Debugger
- Type checking by pyright via one of: Cursor Python if using Cursor, Pylance if VSCode
- Ty (astral type checker)
- Ruff
- Svelte for VS Code
- Vitest
Expand Down
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
<a href="https://docs.getkiln.ai"><strong>Docs</strong></a>
</p>

| | |
| ------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| | |
| ------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| CI | [![Build and Test](https://github.com/Kiln-AI/kiln/actions/workflows/build_and_test.yml/badge.svg)](https://github.com/Kiln-AI/kiln/actions/workflows/build_and_test.yml) [![Format and Lint](https://github.com/Kiln-AI/kiln/actions/workflows/format_and_lint.yml/badge.svg)](https://github.com/Kiln-AI/kiln/actions/workflows/format_and_lint.yml) [![Desktop Apps Build](https://github.com/Kiln-AI/kiln/actions/workflows/build_desktop.yml/badge.svg)](https://github.com/Kiln-AI/kiln/actions/workflows/build_desktop.yml) [![Web UI Build](https://github.com/Kiln-AI/kiln/actions/workflows/web_format_lint_build.yml/badge.svg)](https://github.com/Kiln-AI/kiln/actions/workflows/web_format_lint_build.yml) [![Docs](https://github.com/Kiln-AI/Kiln/actions/workflows/build_docs.yml/badge.svg)](https://github.com/Kiln-AI/Kiln/actions/workflows/build_docs.yml) |
| Tests | [![Test Count Badge](https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/scosman/57742c1b1b60d597a6aba5d5148d728e/raw/test_count_kiln.json)](https://github.com/Kiln-AI/kiln/actions/workflows/test_count.yml) [![Test Coverage Badge](https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/scosman/57742c1b1b60d597a6aba5d5148d728e/raw/library_coverage_kiln.json)](https://github.com/Kiln-AI/kiln/actions/workflows/test_count.yml) |
| Package | [![PyPI - Version](https://img.shields.io/pypi/v/kiln-ai.svg?logo=pypi&label=PyPI&logoColor=gold)](https://pypi.org/project/kiln-ai/) [![PyPI - Python Version](https://img.shields.io/pypi/pyversions/kiln-ai.svg?logo=python&label=Python&logoColor=gold)](https://pypi.org/project/kiln-ai/) |
| Meta | [![uv](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/uv/main/assets/badge/v0.json)](https://github.com/astral-sh/uv) [![linting - Ruff](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json)](https://github.com/astral-sh/ruff) [![types - Pyright](https://img.shields.io/badge/types-pyright-blue.svg)](https://github.com/microsoft/pyright) [![Docs](https://img.shields.io/badge/docs-pdoc-blue)](https://kiln-ai.github.io/Kiln/kiln_core_docs/index.html) |
| Apps | [![MacOS](https://img.shields.io/badge/MacOS-black?logo=apple)](https://getkiln.ai/download) [![Windows](https://img.shields.io/badge/Windows-0067b8.svg?logo=data:image/svg%2bxml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPHN2ZyBmaWxsPSIjZmZmIiB2aWV3Qm94PSIwIDAgMzIgMzIiIHZlcnNpb249IjEuMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KPHBhdGggZD0iTTE2Ljc0MiAxNi43NDJ2MTQuMjUzaDE0LjI1M3YtMTQuMjUzek0xLjAwNCAxNi43NDJ2MTQuMjUzaDE0LjI1NnYtMTQuMjUzek0xNi43NDIgMS4wMDR2MTQuMjU2aDE0LjI1M3YtMTQuMjU2ek0xLjAwNCAxLjAwNHYxNC4yNTZoMTQuMjU2di0xNC4yNTZ6Ij48L3BhdGg+Cjwvc3ZnPg==)](https://getkiln.ai/download) [![Linux](https://img.shields.io/badge/Linux-444444?logo=linux&logoColor=ffffff)](https://getkiln.ai/download) ![Github Downsloads](https://img.shields.io/github/downloads/kiln-ai/kiln/total) |
| Connect | [![Discord](https://img.shields.io/badge/Discord-Kiln_AI-blue?logo=Discord&logoColor=white)](https://getkiln.ai/discord) [![Newsletter](https://img.shields.io/badge/Newsletter-subscribe-blue?logo=mailboxdotorg&logoColor=white)](https://getkiln.ai/blog) |
| Tests | [![Test Count Badge](https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/scosman/57742c1b1b60d597a6aba5d5148d728e/raw/test_count_kiln.json)](https://github.com/Kiln-AI/kiln/actions/workflows/test_count.yml) [![Test Coverage Badge](https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/scosman/57742c1b1b60d597a6aba5d5148d728e/raw/library_coverage_kiln.json)](https://github.com/Kiln-AI/kiln/actions/workflows/test_count.yml) |
| Package | [![PyPI - Version](https://img.shields.io/pypi/v/kiln-ai.svg?logo=pypi&label=PyPI&logoColor=gold)](https://pypi.org/project/kiln-ai/) [![PyPI - Python Version](https://img.shields.io/pypi/pyversions/kiln-ai.svg?logo=python&label=Python&logoColor=gold)](https://pypi.org/project/kiln-ai/) |
| Meta | [![uv](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/uv/main/assets/badge/v0.json)](https://github.com/astral-sh/uv) [![linting - Ruff](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json)](https://github.com/astral-sh/ruff) [![types - ty](https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/scosman/8011394107e99730fd39a1dab98c7748/raw/97e757c3ef60a3d32df633ac70d279534d117707/ty_badge.json)](https://github.com/astral-sh/ty) [![Docs](https://img.shields.io/badge/docs-pdoc-blue)](https://kiln-ai.github.io/Kiln/kiln_core_docs/index.html) |
| Apps | [![MacOS](https://img.shields.io/badge/MacOS-black?logo=apple)](https://getkiln.ai/download) [![Windows](https://img.shields.io/badge/Windows-0067b8.svg?logo=data:image/svg%2bxml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPHN2ZyBmaWxsPSIjZmZmIiB2aWV3Qm94PSIwIDAgMzIgMzIiIHZlcnNpb249IjEuMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KPHBhdGggZD0iTTE2Ljc0MiAxNi43NDJ2MTQuMjUzaDE0LjI1M3YtMTQuMjUzek0xLjAwNCAxNi43NDJ2MTQuMjUzaDE0LjI1NnYtMTQuMjUzek0xNi43NDIgMS4wMDR2MTQuMjU2aDE0LjI1M3YtMTQuMjU2ek0xLjAwNCAxLjAwNHYxNC4yNTZoMTQuMjU2di0xNC4yNTZ6Ij48L3BhdGg+Cjwvc3ZnPg==)](https://getkiln.ai/download) [![Linux](https://img.shields.io/badge/Linux-444444?logo=linux&logoColor=ffffff)](https://getkiln.ai/download) ![Github Downsloads](https://img.shields.io/github/downloads/kiln-ai/kiln/total) |
| Connect | [![Discord](https://img.shields.io/badge/Discord-Kiln_AI-blue?logo=Discord&logoColor=white)](https://getkiln.ai/discord) [![Newsletter](https://img.shields.io/badge/Newsletter-subscribe-blue?logo=mailboxdotorg&logoColor=white)](https://getkiln.ai/blog) |

[<img width="220" alt="Download button" src="https://github.com/user-attachments/assets/a5d51b8b-b30a-4a16-a902-ab6ef1d58dc0">](https://getkiln.ai/download) [<img width="220" alt="Quick start button" src="https://github.com/user-attachments/assets/aff1b35f-72c0-4286-9b28-40a415558359">](https://docs.getkiln.ai/getting-started/quickstart)

Expand Down
29 changes: 21 additions & 8 deletions app/desktop/studio_server/finetune_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
import httpx
from fastapi import FastAPI, HTTPException
from fastapi.responses import StreamingResponse
from kiln_ai.adapters.fine_tune.base_finetune import FineTuneParameter, FineTuneStatus
from kiln_ai.adapters.fine_tune.base_finetune import (
BaseFinetuneAdapter,
FineTuneParameter,
FineTuneStatus,
)
from kiln_ai.adapters.fine_tune.dataset_formatter import (
DatasetFormat,
DatasetFormatter,
Expand Down Expand Up @@ -50,6 +54,19 @@
logger = logging.getLogger(__name__)


def base_provider_from_str_id(provider_str: str) -> type[BaseFinetuneAdapter]:
"""
Validates that a provider string is a valid ModelProviderName and returns the enum value.
"""
if provider_str not in finetune_registry: # type: ignore
valid_providers = list(finetune_registry.keys())
raise HTTPException(
status_code=400,
detail=f"Invalid provider '{provider_str}'. Valid providers are: {valid_providers}",
)
return finetune_registry[provider_str] # type: ignore


class FinetuneProviderModel(BaseModel):
"""Finetune provider model: a model a provider supports for fine-tuning"""

Expand Down Expand Up @@ -208,7 +225,7 @@ async def finetune(
status_code=400,
detail=f"Fine tune provider '{finetune.provider}' not found",
)
finetune_adapter = finetune_registry[finetune.provider]
finetune_adapter = base_provider_from_str_id(finetune.provider)
status = await finetune_adapter(finetune).status()
return FinetuneWithStatus(finetune=finetune, status=status)

Expand Down Expand Up @@ -276,11 +293,7 @@ async def finetune_providers() -> list[FinetuneProvider]:
async def finetune_hyperparameters(
provider_id: str,
) -> list[FineTuneParameter]:
if provider_id not in finetune_registry:
raise HTTPException(
status_code=400, detail=f"Fine tune provider '{provider_id}' not found"
)
finetune_adapter_class = finetune_registry[provider_id]
finetune_adapter_class = base_provider_from_str_id(provider_id)
return finetune_adapter_class.available_parameters()

@app.get("/api/projects/{project_id}/tasks/{task_id}/finetune_dataset_info")
Expand Down Expand Up @@ -358,7 +371,7 @@ async def create_finetune(
status_code=400,
detail=f"Fine tune provider '{request.provider}' not found",
)
finetune_adapter_class = finetune_registry[request.provider]
finetune_adapter_class = base_provider_from_str_id(request.provider)

dataset = DatasetSplit.from_id_and_parent_path(request.dataset_id, task.path)
if dataset is None:
Expand Down
Loading
Loading