fix(vertex): normalize Claude Opus 4.6 legacy model-id aliases by Olusammytee · Pull Request #5969 · Kilo-Org/kilocode

Olusammytee · 2026-02-18T00:56:13Z

Summary

switch the Vertex Claude Opus 4.6 catalog entry to canonical claude-opus-4-6
add
ormalizeVertexModelId in types to map legacy aliases (claude-opus-4-6@default, claude-opus-4-6@vertex) to the canonical ID
use normalization in Vertex runtime handlers and webview selected-model hook so saved legacy config is auto-corrected
add regression tests in packages/types, src/api/providers, and webview-ui

Why

Some saved Vertex configurations use a legacy alias for Opus 4.6, which can lead to invalid API model names and request failures. This keeps backward compatibility while always sending valid model IDs.

Fixes #5772

changeset-bot · 2026-02-18T00:56:20Z

🦋 Changeset detected

Latest commit: e688abc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
kilo-code	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

Normalizes the Vertex AI model id used for Claude Opus 4.6 so legacy saved aliases don’t produce invalid Vertex model names (avoiding 404s) while keeping backward compatibility across runtime and UI selection.

Changes:

Switch Vertex catalog entry for Opus 4.6 to the canonical claude-opus-4-6.
Add normalizeVertexModelId() in @roo-code/types and apply it in Vertex runtime handlers and webview model selection.
Add regression tests across packages/types, extension provider handlers, and the webview UI hook.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
webview-ui/src/components/ui/hooks/useSelectedModel.ts	Normalizes Vertex model ids before lookup/selection.
webview-ui/src/components/ui/hooks/tests/useSelectedModel.spec.ts	Adds UI regression test for legacy Vertex alias normalization.
src/api/providers/vertex.ts	Normalizes Vertex model id in handler model resolution.
src/api/providers/anthropic-vertex.ts	Normalizes Vertex model id in Anthropic-on-Vertex handler model resolution.
src/api/providers/tests/vertex.spec.ts	Adds regression test for VertexHandler legacy alias normalization.
src/api/providers/tests/anthropic-vertex.spec.ts	Adds regression test for AnthropicVertexHandler legacy alias normalization.
packages/types/src/providers/vertex.ts	Updates canonical model key and adds `normalizeVertexModelId()` helper.
packages/types/src/providers/tests/vertex.spec.ts	Adds unit tests for `normalizeVertexModelId()`.

Copilot · 2026-02-18T01:01:05Z

src/api/providers/anthropic-vertex.ts

 	getModel() {
 		const modelId = this.options.apiModelId
-		let id = modelId && modelId in vertexModels ? (modelId as VertexModelId) : vertexDefaultModelId
+		let id: VertexModelId = modelId ? normalizeVertexModelId(modelId) : normalizeVertexModelId("")
 		let info: ModelInfo = vertexModels[id]


The changes in getModel() (using normalizeVertexModelId) aren’t marked with kilocode_change comments. Please annotate the modified lines so this fork-specific behavior is easy to identify/merge against upstream later.

Copilot · 2026-02-18T01:01:05Z

packages/types/src/providers/__tests__/vertex.spec.ts

@@ -0,0 +1,16 @@
+import { normalizeVertexModelId } from "../vertex.js"


New file is missing the required // kilocode_change - new file header comment. Please add it at the top so the fork’s changes remain easy to track during upstream merges.

Copilot · 2026-02-18T01:01:05Z

packages/types/src/providers/vertex.ts

+/**
+ * Normalize legacy Vertex model IDs to canonical IDs.
+ *
+ * Legacy aliases are kept here to support existing saved settings while ensuring
+ * API requests use valid Vertex model names.
+ */
+export function normalizeVertexModelId(modelId: string): VertexModelId {
+	const normalized = modelId.trim()
+
+	// Use Object.hasOwn() instead of 'in' to avoid inherited properties.
+	if (Object.hasOwn(vertexModels, normalized)) {
+		return normalized as VertexModelId
+	}
+
+	switch (normalized.toLowerCase()) {
+		case "claude-opus-4-6@default":
+		case "claude-opus-4-6@vertex":
+			return "claude-opus-4-6"
+		default:
+			return vertexDefaultModelId
+	}
+}


The newly added normalizeVertexModelId block isn’t marked with kilocode_change comments. Please wrap this new block with // kilocode_change start / // kilocode_change end (or annotate the modified lines) to follow the repo’s merge-tracking convention.

Copilot · 2026-02-18T01:01:05Z

webview-ui/src/components/ui/hooks/useSelectedModel.ts

 	openAiModelInfoSaneDefaults,
 	openAiNativeModels,
 	vertexModels,
+	normalizeVertexModelId,


The added normalizeVertexModelId import isn’t annotated with kilocode_change, even though this file uses that convention elsewhere. Please add the appropriate kilocode_change marker for this added import to keep merge tracking consistent.

Suggested change

normalizeVertexModelId,

normalizeVertexModelId, // kilocode_change

Copilot · 2026-02-18T01:01:06Z

webview-ui/src/components/ui/hooks/useSelectedModel.ts

 		case "vertex": {
-			const id = apiConfiguration.apiModelId ?? defaultModelId
+			const rawId = apiConfiguration.apiModelId ?? defaultModelId
+			const id = normalizeVertexModelId(rawId)
 			const info = vertexModels[id as keyof typeof vertexModels]
 			return { id, info }


The Vertex model-id normalization logic added in this vertex provider case isn’t marked with a kilocode_change comment. Please annotate the changed lines (or wrap the case block) to match the established change-marking convention used throughout this file.

Copilot · 2026-02-18T01:01:06Z

src/api/providers/vertex.ts

 	override getModel() {
 		const modelId = this.options.apiModelId
-		let id = modelId && modelId in vertexModels ? (modelId as VertexModelId) : vertexDefaultModelId
+		let id: VertexModelId = modelId ? normalizeVertexModelId(modelId) : normalizeVertexModelId("")
 		const info: ModelInfo = vertexModels[id]
 		const params = getModelParams({ format: "gemini", modelId: id, model: info, settings: this.options })


The changes in getModel() (using normalizeVertexModelId) aren’t marked with kilocode_change comments. Please annotate the modified lines so this fork-specific behavior is easy to identify/merge against upstream later.

Olusammytee · 2026-02-20T11:50:55Z

Rebased onto latest main and resolved merge conflicts.

Kept the Vertex Claude Opus 4.6 alias normalization changes
Preserved the existing gemini-3.1-pro-preview native-tools coverage in vertex.spec.ts

This PR should now be conflict-free and ready for review.

kilo-code-bot · 2026-02-20T11:53:40Z

src/api/providers/__tests__/vertex.spec.ts

-				apiModelId: "gemini-3.1-pro-preview",
-				vertexProjectId: "test-project",
-				vertexRegion: "us-central1",
+			it("should normalize legacy claude-opus-4-6 aliases", () => {


WARNING: Indentation inconsistency — this test and the block below (lines 153–178) are indented with 3 tabs, but the sibling test "should return correct model info for Gemini" at line 137 uses 2 tabs. The extra indentation level makes the nesting appear deeper than it actually is.

Please re-indent lines 153–178 to use 2-tab indentation to match the surrounding describe("getModel") block.

kilo-code-bot · 2026-02-20T11:53:40Z

src/api/providers/__tests__/anthropic-vertex.spec.ts

 			expect(modelInfo.info.contextWindow).toBe(200_000)
 		})

+		it("should normalize legacy claude-opus-4-6 aliases", () => {


WARNING: Missing kilocode_change marker — this new test is a Kilo Code-specific addition to a shared upstream file in src/. Per AGENTS.md, it should be wrapped with // kilocode_change start / // kilocode_change end markers to minimize merge conflicts during upstream syncs.

kilo-code-bot · 2026-02-20T11:53:55Z

Code Review Summary

Status: 11 Issues Found | Recommendation: Address before merge

Fix these issues in Kilo Cloud

Overview

Severity	Count
CRITICAL	0
WARNING	7
SUGGESTION	4

Issue Details (click to expand)

WARNING

File	Line	Issue
`packages/types/src/providers/vertex.ts`	620	Missing `kilocode_change` end marker for the `normalizeVertexModelId` block
`src/api/providers/__tests__/anthropic-vertex.spec.ts`	842	Missing `kilocode_change` marker on new test block
`src/api/providers/__tests__/vertex.spec.ts`	154	Missing `kilocode_change` marker on new test block
`src/api/providers/__tests__/vertex.spec.ts`	N/A	Indentation inconsistency in test file
`webview-ui/src/components/ui/hooks/__tests__/useSelectedModel.spec.ts`	N/A	Missing `kilocode_change` marker on new test block
`webview-ui/src/components/ui/hooks/__tests__/useSelectedModel.spec.ts`	795-834	Indentation regression — new `vertex provider` block uses extra tab, and the existing `litellm provider` block was shifted to 2 tabs (was 1 tab), breaking consistency with the rest of the file
`webview-ui/src/components/ui/hooks/useSelectedModel.ts`	N/A	Missing `kilocode_change` annotation on `normalizeVertexModelId` import

SUGGESTION

File	Line	Issue
`packages/types/src/providers/vertex.ts`	613	Inconsistent case handling — `Object.hasOwn()` check is case-sensitive but the `switch` uses `.toLowerCase()`. A mixed-case input like `"Claude-Opus-4-6"` would bypass `Object.hasOwn` and fall through to the default, silently returning the default model instead of matching
`src/api/providers/anthropic-vertex.ts`	227	`normalizeVertexModelId("")` is unnecessarily verbose — the ternary could be simplified to `normalizeVertexModelId(modelId \|\| "")`
`src/api/providers/vertex.ts`	18	Same redundant ternary pattern as anthropic-vertex.ts
`webview-ui/src/components/ui/hooks/useSelectedModel.ts`	301	Vertex model-id normalization logic added without full `kilocode_change` block markers

Files Reviewed (8 files)

.changeset/silver-cups-bow.md - 0 issues
packages/types/src/providers/__tests__/vertex.spec.ts - 0 issues (marker present)
packages/types/src/providers/vertex.ts - 2 issues
src/api/providers/__tests__/anthropic-vertex.spec.ts - 1 issue
src/api/providers/__tests__/vertex.spec.ts - 2 issues
src/api/providers/anthropic-vertex.ts - 1 issue
src/api/providers/vertex.ts - 1 issue
webview-ui/src/components/ui/hooks/__tests__/useSelectedModel.spec.ts - 2 issues
webview-ui/src/components/ui/hooks/useSelectedModel.ts - 2 issues

Olusammytee · 2026-02-20T23:23:52Z

Addressed the latest kiloconnect review items in commit b42cf82:

Re-indented the new getModel tests in src/api/providers/__tests__/vertex.spec.ts to match surrounding nesting.
Added // kilocode_change start/end markers around the new alias-normalization test in src/api/providers/__tests__/anthropic-vertex.spec.ts.

Please re-run review/CI.

kilo-code-bot · 2026-02-20T23:26:48Z

src/api/providers/__tests__/vertex.spec.ts

 			expect(modelInfo.info.contextWindow).toBe(1048576)
 		})

+		it("should normalize legacy claude-opus-4-6 aliases", () => {


WARNING: Missing kilocode_change marker — this new test modifies a file that exists in upstream Roo Code (src/), so it needs kilocode_change markers to minimize merge conflicts during upstream syncs. The equivalent test in anthropic-vertex.spec.ts correctly includes the markers.

Suggested change

it("should normalize legacy claude-opus-4-6 aliases", () => {

// kilocode_change start

it("should normalize legacy claude-opus-4-6 aliases", () => {

kilo-code-bot · 2026-02-20T23:26:48Z

webview-ui/src/components/ui/hooks/__tests__/useSelectedModel.spec.ts

 		})
 	})

+	describe("vertex provider", () => {


WARNING: Missing kilocode_change marker — this new test block modifies a file in webview-ui/, which requires kilocode_change markers per project conventions.

Suggested change

describe("vertex provider", () => {

// kilocode_change start

describe("vertex provider", () => {

Also add a // kilocode_change end comment after the closing }) of this describe block (after line 830).

Olusammytee · 2026-02-21T20:20:21Z

Addressed the latest kiloconnect marker/style warnings in commit e90005d:

Added kilocode_change markers around normalizeVertexModelId usage in src/api/providers/vertex.ts and src/api/providers/anthropic-vertex.ts.
Wrapped normalizeVertexModelId block in packages/types/src/providers/vertex.ts with markers.
Added // kilocode_change - new file header to packages/types/src/providers/__tests__/vertex.spec.ts.
Annotated Vertex normalization import/logic in webview-ui/src/components/ui/hooks/useSelectedModel.ts.
Added markers around the new vertex-provider test block in webview-ui/src/components/ui/hooks/__tests__/useSelectedModel.spec.ts.
Added markers around the Vertex alias normalization test and cleaned the trailing indentation in src/api/providers/__tests__/vertex.spec.ts.

Please re-run review.

kilo-code-bot · 2026-02-21T20:22:25Z

packages/types/src/providers/vertex.ts

+		return normalized as VertexModelId
+	}
+
+	switch (normalized.toLowerCase()) {


SUGGESTION: Inconsistent case handling — Object.hasOwn() on line 609 is case-sensitive, but the switch here uses .toLowerCase(). If a canonical model ID were ever passed with unexpected casing (e.g. "Claude-Opus-4-6"), it would skip the Object.hasOwn check, miss all switch cases (since "claude-opus-4-6" isn't listed as a legacy alias), and silently fall through to vertexDefaultModelId.

In practice this is unlikely since model IDs are always lowercase, but for defensive consistency consider also lowercasing the Object.hasOwn lookup, or adding a comment explaining the intentional asymmetry.

Copilot AI reviewed Feb 18, 2026

View reviewed changes

Olusammytee added 2 commits February 20, 2026 06:50

fix: normalize Vertex Claude Opus 4.6 model id aliases

1173290

chore: add changeset for vertex opus 4.6 alias normalization

902a33f

kilo-code-bot bot reviewed Feb 20, 2026

View reviewed changes

test(vertex): fix review nits for markers and indentation

b42cf82

kilo-code-bot bot reviewed Feb 20, 2026

View reviewed changes

chore: add kilocode_change markers for vertex alias updates

e90005d

kilo-code-bot bot reviewed Feb 21, 2026

View reviewed changes

Update changeset

e688abc

kevinvandijk approved these changes Feb 21, 2026

View reviewed changes

kevinvandijk merged commit 05cff0b into Kilo-Org:main Feb 21, 2026
9 checks passed

		@@ -0,0 +1,16 @@
		import { normalizeVertexModelId } from "../vertex.js"

	normalizeVertexModelId,
	normalizeVertexModelId, // kilocode_change

	it("should normalize legacy claude-opus-4-6 aliases", () => {
	// kilocode_change start
	it("should normalize legacy claude-opus-4-6 aliases", () => {

	describe("vertex provider", () => {
	// kilocode_change start
	describe("vertex provider", () => {

Conversation

Olusammytee commented Feb 18, 2026

Summary

Why

Uh oh!

changeset-bot bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Olusammytee commented Feb 20, 2026

Uh oh!

kilo-code-bot bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Overview

WARNING

SUGGESTION

Uh oh!

Olusammytee commented Feb 20, 2026

Uh oh!

kilo-code-bot bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Olusammytee commented Feb 21, 2026

Uh oh!

kilo-code-bot bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Feb 18, 2026 •

edited

Loading

kilo-code-bot bot commented Feb 20, 2026 •

edited

Loading