fix: allow dropdowns in Modes modal to be changed#5992
Open
shssoichiro wants to merge 1 commit intoKilo-Org:mainfrom
Open
fix: allow dropdowns in Modes modal to be changed#5992shssoichiro wants to merge 1 commit intoKilo-Org:mainfrom
shssoichiro wants to merge 1 commit intoKilo-Org:mainfrom
Conversation
Currently if a user clicks either of the dropdowns (Mode or API Configuration) within the Modes modal, the modal will close, and their action will not save. This change prevents the close-on-click action from affecting the dropdowns which are rendered in a portal outside of the modal, so that the dropdowns work as intended.
🦋 Changeset detectedLatest commit: 23a083a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently if a user clicks either of the dropdowns (Mode or API Configuration) within the Modes modal, the modal will close, and their action will not save.
Implementation
This change prevents the close-on-click action from affecting the dropdowns which are rendered in a portal outside of the modal, so that the dropdowns work as intended.
How to Test