fix(plan): restore unconditional plan_exit tool registration#6699
Merged
alex-alecu merged 4 commits intomainfrom Mar 6, 2026
Merged
fix(plan): restore unconditional plan_exit tool registration#6699alex-alecu merged 4 commits intomainfrom
alex-alecu merged 4 commits intomainfrom
Conversation
A merge conflict resolution incorrectly gated PlanExitTool behind KILO_EXPERIMENTAL_PLAN_MODE && KILO_CLIENT === "cli", preventing the plan agent from signaling completion. This broke the "looks good, implement" flow — the follow-up prompt never appeared and no new code-mode session was created. Regression of #6240.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional issues found outside the diff. Files Reviewed (2 files)
|
BatchTool rebuilds its tool map from ToolRegistry.tools() without passing the caller agent, so agent-level permission filtering is bypassed. Add plan_exit to the DISALLOWED set to prevent non-plan agents from triggering it via batch.
jeanduplessis
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlanExitToolbehindKILO_EXPERIMENTAL_PLAN_MODE && KILO_CLIENT === "cli", which meant the plan agent could never signal completion on VS Code (or CLI without the experimental flag)PlanExitToolto unconditional registration (it's already gated by agent permissions)Regression of #6240.