Skip to content

Conversation

yuehuang010
Copy link
Contributor

Add Command Line Diff Tool

  • A "Compare" button to CommandLineArgument text editor to spawn Command Line Diff Tool.
  • Command Line Diff Tool performs a text compare and a "smarter" tokenize comparison.
  • Fix CommandLineArgument to allow multiple unique tabs.
image

@yuehuang010 yuehuang010 marked this pull request as ready for review July 28, 2025 05:29
@KirillOsenkov
Copy link
Owner

Hi Felix, honestly I'm on the fence about taking this one. It seems like it would be well-suited for a stand-alone separate tool.

I usually use a separate tool, I paste the left command line, the right command line, split into lines, sort, and it shows the diff visually:
image

I'm sorry because I see that a lot of your effort went into this and I feel bad. Perhaps if we had extensions this would have been a good candidate for an extension. But I also wouldn't want to add support for extensions because that's a lot of maintenance and support burden.

@yuehuang010
Copy link
Contributor Author

No worries. It was a fun coding challenge.

A regular diff tool may not handle switch reordering or path changes between different binlog (not implemented). Being part of the BinLog Viewer can take advantage of the project context for a more accurate comparison.

@paulomorgado
Copy link
Contributor

No worries. It was a fun coding challenge.

A regular diff tool may not handle switch reordering or path changes between different binlog (not implemented). Being part of the BinLog Viewer can take advantage of the project context for a more accurate comparison.

Now, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants