Avoid nested flushes #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Oct 17, 2025
Justineantoine
force-pushed
the
avoid-nested-flushes
branch
from
22abfc5 to
3f12885
Compare
|
I like it and I was thinking of a context manager too for dealing with the flushing scope... LGTM, let me know if you need me to merge... |
Justineantoine
force-pushed
the
avoid-nested-flushes
branch
2 times, most recently
from
3559320 to
1de86e7
Compare
jourdain
reviewed
Oct 22, 2025
jourdain
reviewed
Oct 22, 2025
jourdain
reviewed
Oct 22, 2025
jourdain
reviewed
Oct 22, 2025
jourdain
reviewed
Oct 22, 2025
jourdain
reviewed
Oct 22, 2025
Justineantoine
force-pushed
the
avoid-nested-flushes
branch
from
1de86e7 to
a19168b
Compare
jourdain
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed example: you were right about the layout in layout, everything was fine until i added a ServerTemplate in a child layout and it displayed itself in both the parent and the child.
To avoid to call state.flush() if the state is already flushing, i added a _is_flushing attribute to the State class