fix(tracing): omit http.route span attribute when route has no paths#14852
Open
officialasishkumar wants to merge 1 commit intoKong:masterfrom
Open
fix(tracing): omit http.route span attribute when route has no paths#14852officialasishkumar wants to merge 1 commit intoKong:masterfrom
officialasishkumar wants to merge 1 commit intoKong:masterfrom
Conversation
Per the OpenTelemetry semantic conventions, the `http.route` attribute must not be set on the span when the route is not known. Previously, Kong emitted an empty string as the value of `http.route` when the matched route had no paths defined, violating the specification. Only set the `http.route` attribute when the route has an actual path value, and add a regression test to verify the attribute is omitted for host-only routes. Fix Kong#14845 Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per the OpenTelemetry semantic conventions, the
http.routeattribute must not be set on the span when the route is not known. Previously, Kong emitted an empty string as the value ofhttp.routewhen the matched route had no paths defined (e.g., host-only routes), violating the specification.This change makes
http.routeonly be set when the route has an actual path value. When no path is available, the attribute is omitted entirely.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #14845