-
Notifications
You must be signed in to change notification settings - Fork 613
Fix KongUpstreamPolicy to respect healchecks.thresholds #7756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
| return &kong.Healthcheck{ | ||
| Active: translateActiveHealthcheck(healthchecks.Active), | ||
| Passive: translatePassiveHealthcheck(healthchecks.Passive), | ||
| Thresholds: healthchecks.Thresholds, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be heatlthchecks.Threshold. Also, since the types are different in CRD and Kong SDK (*int64 and *flaot64), there should be a translateThreshold function to run the transferring like
func translateThreshold(threshold *int64) *float64 {
if threshold == nil {
return nil
}
return lo.ToPtr(float64(*threshold))
}
|
@elbrogan-vizio Thank you for contributing. |
|
@elbrogan-vizio Thank you for contributing. |
|
While I would like to have worked on this further, unfortunately my company's legal team has not signed off on the CLA. |
Thanks again for your concentration on the issue. From your reply, it shows that you cannot sign our CLA unless your company's legal team allow you to sign it, but they did not give a certain feedback on it. Is that the case you are facing? |
Which issue this PR fixes:
Fixes #7755