Skip to content

Conversation

@elbrogan-vizio
Copy link

Which issue this PR fixes:

Fixes #7755

@elbrogan-vizio elbrogan-vizio requested a review from a team as a code owner October 25, 2025 00:46
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

return &kong.Healthcheck{
Active: translateActiveHealthcheck(healthchecks.Active),
Passive: translatePassiveHealthcheck(healthchecks.Passive),
Thresholds: healthchecks.Thresholds,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be heatlthchecks.Threshold. Also, since the types are different in CRD and Kong SDK (*int64 and *flaot64), there should be a translateThreshold function to run the transferring like

func translateThreshold(threshold *int64) *float64 {
    if threshold == nil {
        return nil
    }
    return lo.ToPtr(float64(*threshold))
}

@randmonkey
Copy link
Contributor

@elbrogan-vizio Thank you for contributing.
We are sorry that we are not able to let CIs pass on PRs submitted so they cannot be merged to main branch now. Would you mind me cherry-picking your commit into another branch and rework on the new branch, so your contribution can be merged?

@randmonkey
Copy link
Contributor

randmonkey commented Nov 5, 2025

@elbrogan-vizio Thank you for contributing.
We want to release a patch to fix the issue #7755 you have submitted.
Would you please update the PR according to my comments? If you do not have the time to update your PR before this Friday, we will do the fix in another PR with your commit cherry-picked to our PR.
Also, it requires you to sign the CLA to make your commit be able to merge. If you do not sign the CLA, your commit cannot be merged and we have to fix the issue WITHOUT your commit.

@elbrogan-vizio
Copy link
Author

While I would like to have worked on this further, unfortunately my company's legal team has not signed off on the CLA.

@randmonkey
Copy link
Contributor

randmonkey commented Nov 12, 2025

While I would like to have worked on this further, unfortunately my company's legal team has not signed off on the CLA.

Thanks again for your concentration on the issue. From your reply, it shows that you cannot sign our CLA unless your company's legal team allow you to sign it, but they did not give a certain feedback on it. Is that the case you are facing?
We are also waiting for the input of legal team of our company if it is OK to merge our own fix without your commits and mention your contribution in our changelog and commit message. (we are sorry if we have to take this solution since it does not respect your ownership and contribution, but it could unblock the legal team of your company to allow you to sign the CLA)

@tao12345666333 tao12345666333 mentioned this pull request Nov 12, 2025
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KongUpstreamPolicy healthchecks.threshold is not respected and defaults to 0.

3 participants