[Backport release/2.12.x]fix(sendconfig): Do not cleanup nulls in plugin configuration (#7751)
#7780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove cleanup of nulls in plugin config * update tests * update changelog * dump plugin config in tests * find plugin in multiple plugins * use different paths for plugin tests and fix workspace (cherry picked from commit 2bb2029)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove cleanup of nulls in plugin config
update tests
update changelog
dump plugin config in tests
find plugin in multiple plugins
use different paths for plugin tests and fix workspace
(cherry picked from commit 2bb2029)
What this PR does / why we need it:
Backport #7751 to
release/2.12.x.Which issue this PR fixes:
fixes #7777
Special notes for your reviewer:
Since the github.com/kong/go-kong 0.56.0 fills ALL field with
nulls with default value, this does not really fix the issue and the integration tests cannot pass.go-kong 0.60.0 is the earliest version that fixed this, but signature of
Client.ReloadDeclarativeRawConfighas changed. We need to choose one:go-kongto 0.60.0 and modify affected interfaces and related code to process the returned errorsrelease/2.12.xPR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR