-
Notifications
You must be signed in to change notification settings - Fork 76
Pivot kdocs #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pivot kdocs #1554
Conversation
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/SelectingColumns.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
Jolanrensen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review more tomorrow :)
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt
Outdated
Show resolved
Hide resolved
| public typealias PivotColumnsSelector<T, C> = Selector<PivotDsl<T>, ColumnsResolver<C>> | ||
|
|
||
| /** | ||
| * An intermediate class used in [`Pivot` reducing][PivotDocs.Reducing] operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI in KDoc rendering, the alias side of []-code references are automatically made code-style. So the backticks do nothing. However, you can leave them because this might change in the future. It's not part of the GFM spec
| interface Pivoting | ||
|
|
||
| /** | ||
| * Grouping key can also be created inline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*A grouping key or *grouping keys
| /** | ||
| * Grouping key can also be created inline | ||
| * (i.g. by creating a new column using [expr] or simply renaming the old one | ||
| * using [named]) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a space in front of :
| /** | ||
| * Pivoted columns can also be created inline | ||
| * (i.g. by creating a new column using [expr] or simply renaming the old one | ||
| * using [named]) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space
| // region pivotMatches | ||
|
|
||
| /** | ||
| * Computes a **presence matrix** (similar to one-hot encoding) for the values in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you link to wikipedia for one-hot-encoding? in case people don't know about it and they are curious :) like here https://en.wikipedia.org/wiki/One-hot#Machine_learning_and_statistics
| * (they become [column groups][ColumnGroup] | ||
| * corresponding to value combinations when using [then][PivotDsl.then], | ||
| * similar to [pivot]); | ||
| * * **Rows** correspond to all unique combinations of values from the {@get [GroupingColumns] grouping} columns; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eyy, nice KoDEx usage ;P Just for funzies, did you know you can also write this like $[GroupingColumns]=grouping? :) (not that it's much more compact or anything, just an alternative if you ever need it)
Jolanrensen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some tiny comments left, feel free to merge it afterwards, it looks good!
Closes #1525
Closes #1552