Ignore exceptions thrown from Thread.UncaughtExceptionHandler #4525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4516
Background
Whenever an uncaught exception happens in a coroutine, it gets reported to the
CoroutineExceptionHandler
. See https://kotlinlang.org/docs/exception-handling.html#coroutineexceptionhandler. However, if it's not installed, a platform-specific handler is used.On the JVM, this means invoking the thread's
UncaughtExceptionHandler
, which logs the exception to the console by default, but can be configured to do other things (for example, on Android, it will crash the application).Problem
User-specified
UncaughtExceptionHandler
instances are allowed to throw exceptions.Java's documentation says so
(https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Thread.UncaughtExceptionHandler.html):
This means a user is allowed to write a throwing
UncaughtExceptionHandler
, and the caller has to deal with it.In our implementation, however, we are simply invoking the exception handler as a plain function, and if that function throws an exception, we allow this exception to propagate to the coroutine machinery, causing it to fail.
Solution
To comply with the contract defined for
UncaughtExceptionHandler
, we also ignore the exceptions thrown from there.