Don't upload strings from third-party code to Transifex #8013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I just discovered a second repo where the latest Transifex translations are auto committed by a bot. @liushuyu then takes those translations and merges them into LMMS every now and then. This bug is also present in that repo's scripts. It feels bad to spread our tools in two places. IMO as much as possible should be in this repo, and only the stuff related to bot committing should be in that second repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of strings from Carla have been uploaded to our Transifex. There's no use translating these since Carla is a separate process and doesn't read our translation files. This PR adds
git ls-filesto only include strings from our files.