Add support for multiple tracks/channels to MidiExport
#8048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Map each instrument track to a different incremental MIDI channel (skipping channel 10) - Map pattern tracks to channel 10 with patch 0, using repeated pattern from pattern editor - Support Sf2 Player patches - General refactoring
|
thanks for keeping the PR alive <3 been eagerly awaiting this since 2021 |
|
Worked with about 10 midi files with this build. Worked amazing no issues other than volume and pitch not exporting. Good work reviving this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #5516, which was 5 years old and whose original fork/branch have since been deleted.
I tried to be careful when rebasing and fixing the conflicts, but there is a chance I made a mistake, so testing is needed.
TODO:
I made minimal changes to the original PR while rebasing, so I plan to do a round of modernization and style fixes to get this more presentable. After that, someone else is free to take over this PR.