Skip to content

Added pressure limit check in MAINSTAGE #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mootz12 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added pressure limit check in MAINSTAGE #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions static_test_driver/autosequence.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
// Max outlet temperature before triggering a shutdown
#define MAX_COOLANT_TEMP 60

#if CONFIGURATION != DEMO
#define MAX_PRESSURE_FUEL 150 //TODO: Cement this value
#define MAX_PRESSURE_OX 150 //TODO: Cement this value
#endif

// Min thrust that must be reached to avoid triggering a no-ignition shutdown
#if CONFIGURATION == DEMO
#define MIN_THRUST 100
Expand Down Expand Up @@ -146,6 +151,17 @@ void run_control() {
Serial.println(F("Thrust below critical level"));
abort_autosequence();
}
// Check that the pressure of the fuel and oxidizer line have not exceeded the maximum limit
Copy link
Member

@krame505 krame505 Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that we only want this check after ignition and mainstage? Seems like we might want to abort before ignition if the line pressures are too high. Unless those sensors are downstream of the valves, in which case ignore this comment.

Copy link
Author

@mootz12 mootz12 Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll double check that with Jame as I'm not positive

Copy link
Contributor

@glenjamin97 glenjamin97 Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do want to check pressures after the prestage valves have opened before ignition.

#if CONFIGURATION != DEMO
else if (run_time >= STARTUP_TIME && pressure_fuel > MAX_PRESSURE_FUEL) {
Serial.println(F("Fuel pressue above critical level"));
Copy link
Member

@krame505 krame505 Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error.

abort_autosequence();
}
else if (run_time >= STARTUP_TIME && pressure_ox > MAX_PRESSURE_OX) {
Serial.println(F("Oxidizer pressure above critical level"));
abort_autosequence();
}
#endif

if (run_time >= RUN_TIME) {
SET_STATE(COOL_DOWN)
Expand Down