Fix/dont close once actions

.changeset/goofy-taxes-walk.md

@@ -0,0 +1,5 @@
+---
+'@orbi-ts/core': patch
+---
+
+don't close successfull once actions in order to keep track of their value

core/actions/src/action-manager.ts

@@ -738,6 +738,16 @@ export class Action {
             this.dbDoc.markModified('cronActivity.nextActivity');
             return this.changeState(ActionState.SLEEPING);
         } else if (this.dbDoc.workflowId) {
+            if (
+                this.dbDoc.workflowCrossStrategy &&
+                this.dbDoc.state === ActionState.SUCCESS
+            ) {
+                this.dbDoc.cronActivity.nextActivity = new Date(
+                    Date.now() + 365 * 24 * 60 * 60 * 1000
+                );
+                this.dbDoc.markModified('cronActivity.nextActivity');
+                return this.dbDoc.save().then(() => ActionState.UNKNOWN); //short circuit
+            }
             return Workflow.findPendingWorkflowUsingAction(this.dbDoc).then(
                 async (workflowDbs) => {
                     const trackingResumePromise = [];

core/actions/src/coalescing-manager.ts

@@ -95,6 +95,9 @@ export abstract class CoalescingWorkflow extends Workflow {
             const actions = await ActionRuntime.activeRuntime.ActionModel.find({
                 workflowRef: ref,
                 workflowIdentity: this.stringifyIdentity(),
+                state: {
+                    $lte: ActionState.SUCCESS, //we do not retain ERROR, only SUCCESS are shared
+                },
             }).sort('createdAt');
             for (const action of actions) {
                 if (!this.registeredActionIds.includes(action.id)) {
@@ -127,6 +130,14 @@ export abstract class CoalescingWorkflow extends Workflow {
         return super.do(ref, opts);
     }
 
+    trackAction(ref: string, action: ActionSchemaInterface) {
+        const strategy = this.mapRefWithStrategy.get(ref);
+        if (strategy === 'cross-workflow') {
+            action.workflowCrossStrategy = true;
+        }
+        return super.trackAction(ref, action);
+    }
+
     async lastOutput() {
         const oldActions = await ActionRuntime.activeRuntime.ActionModel.find({
             identity: this.stringifyIdentity(),

core/actions/src/models/action.ts

@@ -33,6 +33,7 @@ export interface ActionSchemaInterface<
     workflowRef?: string;
     workflowIteration?: number;
     workflowIdentity?: string;
+    workflowCrossStrategy?: boolean;
     workflowStack: {
         ref: string;
         stepIndex: number;
@@ -94,6 +95,7 @@ export const actionSchema = new mongoose.Schema(
         workflowRef: String,
         workflowIteration: Number,
         workflowIdentity: String,
+        workflowCrossStrategy: Boolean,
         generatorCount: Number,
         workflowStack: [
             {

core/actions/src/workflow-manager.ts

@@ -320,7 +320,7 @@ export class Workflow extends Action {
         return this.trackDefine();
     }
 
-    private trackAction(ref: string, action: ActionSchemaInterface) {
+    protected trackAction(ref: string, action: ActionSchemaInterface) {
         this.registeredActionIds.push(action.id);
         if (
             !this.bag.registeredActions.find((descriptor) => {