GitHub Issue 442: don't default to SORT_ASC during clearSort#7436
Merged
GitHub Issue 442: don't default to SORT_ASC during clearSort#7436
Conversation
…at prevents clearSort()
labkey-susanh
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related to the changes made in this PR for https://github.com/LabKey/internal-issues/issues/442
In DataRegion.js _alterSortString (which is called when sort direction changes or is cleared), prior to the previous PR changes it would check for a SORT_ASC direction and use an empty string instead. The change was made so that instead it would check for no direction value and set it to SORT_ASC. This means that when clearSort() calls this function it would set the sort to SORT_ASC instead of clearing it. This resulted in a failure in the ListTest.testCustomViews.
Related Pull Requests
Changes
Tasks 📍
Needs AutomationVerify Fix