Skip to content

Comments

ParticipantReport loadReport() to check reportType before loading saved configuration#7437

Merged
cnathe merged 1 commit intodevelopfrom
fb_participantReportCrawler
Feb 20, 2026
Merged

ParticipantReport loadReport() to check reportType before loading saved configuration#7437
cnathe merged 1 commit intodevelopfrom
fb_participantReportCrawler

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Feb 19, 2026

Rationale

ParticipantReport.js issue found by crawler running TimeChartDateBasedTest. When the ParticipantReport loadReport() takes the report id from the URL and loads the report config, it just assumes the report is of the correct type. However, if you give it a reportId for a different reportType, it will hit this JS error Uncaught TypeError: Cannot read properties of undefined (reading 'length'). This PR updates that loadReport code path to check for the expected ReportService.ParticipantReport before loading the config.

Changes

  • ParticipantReport loadReport() to check reportType before loading saved configuration

Tasks 📍

  • Manual Testing @XingY
  • verify ParticipantReportTest on TC

…ed configuration

- found by crawler running TimeChartDateBasedTest
@cnathe cnathe self-assigned this Feb 19, 2026
@cnathe cnathe requested a review from XingY February 19, 2026 16:25
@cnathe cnathe merged commit fc6eeb9 into develop Feb 20, 2026
8 of 20 checks passed
@cnathe cnathe deleted the fb_participantReportCrawler branch February 20, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants