Skip to content

Conversation

@itislu
Copy link
Collaborator

@itislu itislu commented Jul 24, 2024

It would look like this:
Screenshot from 2024-07-24 13-53-16

Also:

  • Let readline print to stderr (same as bash).
    Bash's behavior can be tested with bash -i 2>/dev/null.
  • Print welcome msg to stderr for consistency with readline.

@itislu itislu added the enhancement Enhancement of an existing feature label Jul 24, 2024
@itislu itislu force-pushed the fix-input-infinite-loop branch from 6f10b26 to e14db14 Compare July 26, 2024 18:28
@itislu
Copy link
Collaborator Author

itislu commented Jul 27, 2024

The test failed because after the changes to the tester it needs the following change: 918116e


Oh I was wrong, the necessary change mentioned above was just so we can see the output of valgrind.
But for some reason, the valgrind trace-children-skip doesn't work for one test case anymore...


@LeaYeh LeaYeh force-pushed the fix-input-infinite-loop branch 2 times, most recently from a132e99 to 61ef9fd Compare August 13, 2024 12:57
@itislu itislu marked this pull request as draft August 13, 2024 13:05
@itislu itislu force-pushed the fix-input-infinite-loop branch from 61ef9fd to 9d9c5c3 Compare August 20, 2024 22:28
@itislu itislu force-pushed the fix-input-infinite-loop branch from 543c899 to 04fc6b3 Compare January 26, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of an existing feature

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants