test(reservation): stabilize full-series recurrence test#1090
Merged
JohnVillalovos merged 1 commit intodevelopfrom Feb 28, 2026
Merged
test(reservation): stabilize full-series recurrence test#1090JohnVillalovos merged 1 commit intodevelopfrom
JohnVillalovos merged 1 commit intodevelopfrom
Conversation
A test failure occurred at certains times when DST would start in the next 10 days. Freeze the current time in ExistingReservationTest::testWhenApplyingRecurrenceUpdatesToFullSeries and derive the test date from a safe midday anchor. This test was using live Date::Now() values, which made the recurrence window sensitive to timezone conversion into the booked-by user's timezone (America/New_York). When the generated 10-day recurrence range crossed a DST boundary or was evaluated near midnight UTC, the local termination date could shift and produce off-by-one instance counts.
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes a flaky reservation recurrence test by removing dependence on the actual current time, which could shift across DST/timezone boundaries and cause off-by-one instance counts.
Changes:
- Freezes
Date::Now()to a fixed midday timestamp for determinism. - Derives the test’s “today” anchor from
TestBase::GetTestDate()(safe mid-day date) instead of liveDate::Now().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test failure occurred at certains times when DST would start in the next 10 days.
Freeze the current time in
ExistingReservationTest::testWhenApplyingRecurrenceUpdatesToFullSeries and derive the test date from a safe midday anchor.
This test was using live Date::Now() values, which made the recurrence window sensitive to timezone conversion into the booked-by user's timezone (America/New_York). When the generated 10-day recurrence range crossed a DST boundary or was evaluated near midnight UTC, the local termination date could shift and produce off-by-one instance counts.