chore: Upgrade jQuery UI assets to 1.14.2#1120
Closed
labmecanicatec wants to merge 1 commit intoLibreBooking:developfrom
Closed
chore: Upgrade jQuery UI assets to 1.14.2#1120labmecanicatec wants to merge 1 commit intoLibreBooking:developfrom
labmecanicatec wants to merge 1 commit intoLibreBooking:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the bundled jQuery UI assets used by the web UI from the legacy 1.12.1 set to 1.14.2, and updates the global header template to reference the new versioned paths (local and CDN).
Changes:
- Switch
tpl/globalheader.tpljQuery UI JS/CSS includes from1.12.1to1.14.2(local vendor + code.jquery.com CDN). - Add jQuery UI
1.14.2vendor assets (minified JS/CSS, images, metadata). - Remove jQuery UI
1.12.1vendor assets (minified JS/CSS, images, metadata).
Reviewed changes
Copilot reviewed 1 out of 45 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tpl/globalheader.tpl | Updates jQuery UI include paths to 1.14.2 (local + CDN) and minor markup formatting. |
| Web/assets/vendor/jquery-ui/1.14.2/metadata.json | Adds metadata for the new bundled jQuery UI version. |
| Web/assets/vendor/jquery-ui/1.14.2/js/jquery-ui.1.14.2.min.js | Adds the new jQuery UI 1.14.2 minified JS bundle. |
| Web/assets/vendor/jquery-ui/1.14.2/css/jquery-ui.1.14.2.min.css | Adds the new jQuery UI 1.14.2 minified theme CSS referencing the new image assets. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-icons_cd0a0a_256x240.png | Adds jQuery UI 1.14.2 theme icon sprite. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-icons_888888_256x240.png | Adds jQuery UI 1.14.2 theme icon sprite. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-icons_454545_256x240.png | Adds jQuery UI 1.14.2 theme icon sprite. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-icons_2e83ff_256x240.png | Adds jQuery UI 1.14.2 theme icon sprite. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-icons_222222_256x240.png | Adds jQuery UI 1.14.2 theme icon sprite. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-bg_highlight-soft_75_cccccc_1x100.png | Adds jQuery UI 1.14.2 theme background image. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-bg_glass_95_fef1ec_1x400.png | Adds jQuery UI 1.14.2 theme background image. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-bg_glass_75_e6e6e6_1x400.png | Adds jQuery UI 1.14.2 theme background image. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-bg_glass_75_dadada_1x400.png | Adds jQuery UI 1.14.2 theme background image. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-bg_glass_65_ffffff_1x400.png | Adds jQuery UI 1.14.2 theme background image. |
| Web/assets/vendor/jquery-ui/1.14.2/css/images/ui-bg_glass_55_fbf9ee_1x400.png | Adds jQuery UI 1.14.2 theme background image. |
| Web/assets/vendor/jquery-ui/1.12.1/metadata.json | Removes legacy jQuery UI 1.12.1 metadata. |
| Web/assets/vendor/jquery-ui/1.12.1/js/jquery-ui.1.12.1.custom.min.js | Removes legacy jQuery UI 1.12.1 minified JS bundle. |
| Web/assets/vendor/jquery-ui/1.12.1/css/jquery-ui.1.12.1.custom.min.css | Removes legacy jQuery UI 1.12.1 minified theme CSS. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_ffffff_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_ffd27a_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_ef8c08_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_cd0a0a_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_888888_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_454545_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_2e83ff_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_228ef1_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-icons_222222_256x240.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_highlight-soft_75_ffe45c_1x100.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_highlight-soft_75_cccccc_1x100.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_highlight-soft_100_eeeeee_1x100.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_gloss-wave_35_f6a828_500x100.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_glass_95_fef1ec_1x400.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_glass_75_e6e6e6_1x400.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_glass_75_dadada_1x400.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_glass_65_ffffff_1x400.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_glass_55_fbf9ee_1x400.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_glass_100_fdf5ce_1x400.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_glass_100_f6f6f6_1x400.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_flat_75_ffffff_40x100.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_flat_10_000000_40x100.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_flat_0_aaaaaa_40x100.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_diagonals-thick_20_666666_40x40.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/ui-bg_diagonals-thick_18_b81900_40x40.png | Removes legacy jQuery UI 1.12.1 image asset. |
| Web/assets/vendor/jquery-ui/1.12.1/css/images/animated-overlay.gif | Removes legacy jQuery UI 1.12.1 image asset. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
18
to
20
| {vendor_js src="jquery-migrate/3.6.0/jquery-migrate-3.6.0.min.js"} | ||
| {vendor_js src="jquery-ui/1.12.1/js/jquery-ui.1.12.1.custom.min.js"} | ||
| {vendor_js src="jquery-ui/1.14.2/js/jquery-ui.1.14.2.min.js"} | ||
| {vendor_js src="bootstrap/5.3.3/js/bootstrap.bundle.min.js"} |
There was a problem hiding this comment.
The new jQuery UI vendor directory includes an extra Windows Mark-of-the-Web file (Web/assets/vendor/jquery-ui/1.14.2/css/jquery-ui.min.css:Zone.Identifier with [ZoneTransfer] ZoneId=3). This isn’t a real asset and should be removed before merge to avoid shipping OS metadata / audit noise; re-download/strip ADS so it doesn’t get committed again.
Collaborator
|
What do you think about adding the source map file and the unminified JS? Also are we sure that this is compatible with jQuery 3.3.1? Should we upgrade jQuery first? |
| {/if} | ||
| {else} | ||
| <link rel="stylesheet" href="https://code.jquery.com/ui/1.12.1/themes/smoothness/jquery-ui.css" type="text/css" /> | ||
| <link rel="stylesheet" href="https://code.jquery.com/ui/1.14.2/themes/smoothness/jquery-ui.css" type="text/css" /> |
Collaborator
There was a problem hiding this comment.
Some AI review feedback.
The CDN CSS link for jQuery UI lacks a Subresource Integrity attribute:
<!-- Missing integrity= and crossorigin= -->
<link rel="stylesheet" href="https://code.jquery.com/ui/1.14.2/themes/smoothness/jquery-ui.css" type="text/css" />
The CDN JS link correctly has an integrity hash. The CSS should too. This was also missing in the old 1.12.1 link, but since this commit touches this line, it's a good time to fix it.
The SRI hash can be generated with:
curl -s https://code.jquery.com/ui/1.14.2/themes/smoothness/jquery-ui.css | openssl dgst -sha384 -binary | openssl base64 -A
Remove legacy jQuery UI 1.12.1 assets (images, minified CSS/JS, metadata) and add jQuery UI 1.14.2 assets (minified CSS, JS, images, metadata). Also update tpl/globalheader.tpl to reference the new/updated UI assets (adjusted paths/markup as needed). This updates the bundled jQuery UI to a newer patch release and cleans up the old files.
labmecanicatec
force-pushed
the
jQueryUI_Update
branch
from
d2447fa to
acafe12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove legacy jQuery UI 1.12.1 assets (images, minified CSS/JS, metadata) and add jQuery UI 1.14.2 assets (minified CSS, JS, images, metadata). Also update tpl/globalheader.tpl to reference the new/updated UI assets (adjusted paths/markup as needed). This updates the bundled jQuery UI to a newer patch release and cleans up the old files.