fix: show the Custom Attribute label name when deleting#1121
Merged
JohnVillalovos merged 1 commit intodevelopfrom Mar 8, 2026
Merged
fix: show the Custom Attribute label name when deleting#1121JohnVillalovos merged 1 commit intodevelopfrom
JohnVillalovos merged 1 commit intodevelopfrom
Conversation
When deleting a Custom Attribute show the label name in the confirmation box. Closes: #1100
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Admin “Manage Attributes” UX by displaying the Custom Attribute’s display label in the delete confirmation modal, aligning with issue #1100’s request to show what’s being deleted.
Changes:
- Updated the delete confirmation modal to include the attribute’s display label.
- Populated the label dynamically in the delete dialog using the existing client-side attribute list data.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tpl/Admin/Attributes/manage_attributes.tpl | Adds a placeholder in the delete modal to display the attribute label. |
| Web/scripts/admin/attributes.js | Looks up the selected attribute and injects its decoded label into the delete modal. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a Custom Attribute show the label name in the confirmation box.
Closes: #1100