fix: allow special characters in passwords for user creation#1123
Merged
JohnVillalovos merged 1 commit intodevelopfrom Mar 8, 2026
Merged
fix: allow special characters in passwords for user creation#1123JohnVillalovos merged 1 commit intodevelopfrom
JohnVillalovos merged 1 commit intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes password handling so special characters (notably &) are preserved when creating/authenticating users, and updates contributor guidance on test naming.
Changes:
- Use
GetRawForm(FormKeys::PASSWORD)instead ofGetForm(...)when reading passwords inManageUsersPageandResourceDisplayPage. - Add PHPUnit coverage to ensure trailing ampersands in passwords are preserved from
$_POST. - Document test file/class naming expectations in
AGENTS.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Pages/Admin/ManageUsersPage.php |
Reads password via raw form input to avoid htmlspecialchars mutation. |
Pages/ResourceDisplayPage.php |
Reads password via raw form input for resource-display login flow. |
tests/Pages/Admin/ManageUsersPageTest.php |
Adds regression test for preserving & in passwords. |
tests/Pages/ResourceDisplayPageTest.php |
Adds regression test for preserving & in passwords. |
AGENTS.md |
Adds clearer guidance on test file/class naming and organization. |
You can also share your feedback on Copilot code review. Take the survey.
JohnVillalovos
force-pushed
the
jlvillal/issue_1096
branch
2 times, most recently
from
8e2bc91 to
fa045b0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 35 out of 35 changed files in this pull request and generated 33 comments.
You can also share your feedback on Copilot code review. Take the survey.
When creating a user, using a password with special characters would not work. Also add better instructions to AGENTS.md about test file naming. Closes: #1096
JohnVillalovos
force-pushed
the
jlvillal/issue_1096
branch
from
fa045b0 to
73884f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a user, using a password with special characters would not work.
Also add better instructions to AGENTS.md about test file naming.
Closes: #1096